Refactor button widgets; add widgets.RadioButton#5781
Draft
Bumber64 wants to merge 7 commits into
Draft
Conversation
Bumber64
changed the title
widgets.ToggleButtonwidgets.RadioButton
* Update widgets.lua - RadioButton * Update and rename toggle_button.lua to radio_button.lua * Update help_button.lua * Update configure_button.lua - Replace GraphicButton * Delete library/lua/gui/widgets/buttons/graphic_button.lua * Update Lua API.rst - Add RadioButton; HelpButton now subclass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
widgets.ConfigureButtonand makewidgets.HelpButtona child of it. Addwidgets.RadioButton, which looks and functions like the buttons in thegui/control-panellist.I don't understand the
---@fieldstuff very well, so I based it on examples as best I could. Needs to be verified.If there's a better way to do what
ConfigureButton:refresh()does, I'd like to know.ConfigureButton:init()has already run by the timeHelpButton:init()is called, so the changes need to be reapplied to the Label widget.Needs changelog entries.