Skip to content

fix/stuck-worship: fix lookup of units current prayer target(s)#1588

Draft
chdoc wants to merge 1 commit into
DFHack:masterfrom
chdoc:fix-stuck-worship
Draft

fix/stuck-worship: fix lookup of units current prayer target(s)#1588
chdoc wants to merge 1 commit into
DFHack:masterfrom
chdoc:fix-stuck-worship

Conversation

@chdoc

@chdoc chdoc commented May 19, 2026

Copy link
Copy Markdown
Member

Issue: fix/stuck-worship considers the possible targets of a prayer to be all the deity links of the person organizing the worship. This is highly dubious, in particular for undedicated temples.

The new function looks up the deity in the prayer sub-activity (to the worship activity in the respective temple) of the praying unit.

@chdoc chdoc added this to 53.10-r2 May 19, 2026
@github-project-automation github-project-automation Bot moved this to Needs review in 53.10-r2 May 19, 2026
@chdoc chdoc added the bugfix label May 19, 2026
@ab9rf

ab9rf commented Jun 24, 2026

Copy link
Copy Markdown
Member

I remember that you did some research on this after this PR was submitted, but don't remember what that research showed. Is this PR still an improvement in light of that? I'm inclined to merge but I wanted to check with you first.

@chdoc

chdoc commented Jul 5, 2026

Copy link
Copy Markdown
Member Author

Sorry for being so unresponsive lately. While I am convinced that the way the prayer target is currently determined is wrong, the way the game currently assigns happy thoughts after praying is also wrong (in the sense that neither is following what the game shows as the prayer target for the unit). I am no longer convinced that fixing this actually makes the situation better. Also, my testing has mostly been done in undedicated temples.

I am downgrading this to draft status until I get around to do some more thorough testing including various dedicated temples.

@chdoc chdoc marked this pull request as draft July 5, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Needs review

Development

Successfully merging this pull request may close these issues.

2 participants