Scheduled weekly dependency update for week 35 - #720
Conversation
📝 WalkthroughWalkthroughThe pull request updates the Sphinx documentation dependency and several development dependency pins. No public or exported entity declarations changed. ChangesDependency updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: 🟡 Moderate · up to This update raises several development dependencies beyond Python 3.9 compatibility, so the existing Python 3.9 CI job will fail during installation before tests run. The dependency pins or CI matrix should be adjusted before merging. Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 95d8ea8b-f040-4c85-a83f-f29269ba52c1
📒 Files selected for processing (2)
docs/requirements-docs.txtrequirements-dev.txt
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.
📜 Review details
⏰ Context from checks skipped due to timeout. (4)
- GitHub Check: build (3.12)
- GitHub Check: build (3.13)
- GitHub Check: build (3.10)
- GitHub Check: build (3.11)
🔇 Additional comments (1)
docs/requirements-docs.txt (1)
7-7: LGTM!
| pytest==8.3.5 | ||
| respx==0.22.0 | ||
| setuptools==84.0.0 | ||
| pytest==9.1.1 |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
#!/bin/bash
set -eu
printf '%s\n' '--- repository conventions and learnings ---'
for f in /tmp/coderabbit-repo-knowledge/dagshub-client-aa1863f7/*/*.md; do
printf '\n### %s\n' "$f"
head -80 "$f"
done
printf '%s\n' '--- changed dependency file ---'
cat -n requirements-dev.txt
printf '%s\n' '--- workflow candidates ---'
fd -i 'python-package.yml' . --type f
printf '%s\n' '--- workflow relevant sections ---'
workflow="$(fd -i 'python-package.yml' . --type f | head -1)"
sed -n '1,80p' "$workflow"
printf '%s\n' '--- project metadata files ---'
fd -i -t f 'pyproject.toml' 'setup.py' 'setup.cfg' 'tox.ini' 'Pipfile' .Repository: DagsHub/client
Length of output: 1188
🏁 Script executed:
#!/bin/bash
set -eu
printf '%s\n' '--- tracked workflow files ---'
git ls-files '.github/workflows/*'
printf '%s\n' '--- workflow matrix and dependency install ---'
workflow="$(git ls-files '.github/workflows/*' | grep -E 'python-package\.yml$' | head -1)"
test -n "$workflow"
grep -n -E -C 4 'python-version|requirements-dev|pip install|matrix|include|exclude' "$workflow"
printf '%s\n' '--- package Requires-Python metadata ---'
python3 - <<'PY'
import json
import urllib.request
for name, version in (
("pytest", "9.1.1"),
("fiftyone", "1.21.0"),
("datasets", "5.0.1"),
):
url = f"https://pypi.org/pypi/{name}/{version}/json"
with urllib.request.urlopen(url, timeout=15) as response:
data = json.load(response)
print(f"{name}=={version}: requires_python={data['info']['requires_python']!r}")
PYRepository: DagsHub/client
Length of output: 3628
🏁 Script executed:
#!/bin/bash
set -eu
for spec in \
'pytest 9.1.1' \
'fiftyone 1.21.0' \
'datasets 5.0.1'
do
set -- $spec
name="$1"
version="$2"
printf '%s: ' "$name==$version"
curl -fsSLk "https://pypi.org/pypi/$name/$version/json" |
jq -r '.info.requires_python'
doneRepository: DagsHub/client
Length of output: 225
Keep the Python 3.9 CI job installable.
.github/workflows/python-package.yml installs requirements-dev.txt for every matrix version, including Python 3.9. pytest==9.1.1, fiftyone==1.21.0, and datasets==5.0.1 require Python 3.10 or newer. Pip therefore rejects these pins before linting and tests. If Python 3.9 remains supported, use compatible pins or Python-version markers. Otherwise, remove Python 3.9 from the matrix.
1 participant
Update sphinx-autodoc-typehints from 3.9.9 to 3.13.4.
The bot wasn't able to find a changelog for this release. Got an idea?
Links
Update setuptools from 80.9.0 to 84.0.0.
Changelog
84.0.0
83.0.0
82.0.1
82.0.0
81.0.0
80.10.2
80.10.1
80.10.0
Links
Update pytest from 8.3.5 to 9.1.1.
Changelog
9.1.1
9.1.0
9.0.3
9.0.2
9.0.1
9.0.0
8.4.2
8.4.1
8.4.0