Skip to content
This repository was archived by the owner on Sep 7, 2026. It is now read-only.

Sync approved changes from OpenWAM-staging (1046687) - #1

Merged
DaivdYuan merged 1 commit into
mainfrom
automation/sync-from-staging
Jun 7, 2026
Merged

DaivdYuan merged 1 commit into
mainfrom
automation/sync-from-staging

Conversation

@DaivdYuan

@DaivdYuan DaivdYuan commented May 31, 2026

Copy link
Copy Markdown
Owner

This draft PR was generated automatically from the reviewed private
OpenWAM-staging/main branch.

Staging commit: 1046687571f39ceb047b5e99eaadcc0ea09534f6

Before merging:

  • Review the complete public diff
  • Confirm that no internal assets, credentials, or private references are present
  • Confirm that CI passes in the public repository

@DaivdYuan
DaivdYuan force-pushed the automation/sync-from-staging branch from 6638e94 to 5a790f5 Compare May 31, 2026 07:56
@DaivdYuan DaivdYuan changed the title Sync approved changes from OpenWAM-staging (24ed312) Sync approved changes from OpenWAM-staging (e2933c9) May 31, 2026
@DaivdYuan
DaivdYuan marked this pull request as ready for review May 31, 2026 07:58
Copilot AI review requested due to automatic review settings May 31, 2026 07:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a public release validation script intended to run tests, detect private artifacts, scan suspicious text, and optionally run gitleaks before publishing from staging.

Changes:

  • Adds scripts/check_public_release.sh.
  • Includes pytest discovery/execution, private-file checks, text scanning, and gitleaks integration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scripts/check_public_release.sh Outdated
@DaivdYuan DaivdYuan changed the title Sync approved changes from OpenWAM-staging (e2933c9) Sync approved changes from OpenWAM-staging (6e50e73) May 31, 2026
@DaivdYuan
DaivdYuan force-pushed the automation/sync-from-staging branch from 5a790f5 to 35f6274 Compare May 31, 2026 08:00
@DaivdYuan
DaivdYuan marked this pull request as draft May 31, 2026 08:00
@DaivdYuan
DaivdYuan force-pushed the automation/sync-from-staging branch from 35f6274 to 45a8449 Compare May 31, 2026 08:01
@DaivdYuan DaivdYuan changed the title Sync approved changes from OpenWAM-staging (6e50e73) Sync approved changes from OpenWAM-staging (a29130c) May 31, 2026
@DaivdYuan
DaivdYuan force-pushed the automation/sync-from-staging branch from 45a8449 to f7432ca Compare May 31, 2026 08:09
@DaivdYuan DaivdYuan changed the title Sync approved changes from OpenWAM-staging (a29130c) Sync approved changes from OpenWAM-staging (df98c20) May 31, 2026
@DaivdYuan
DaivdYuan force-pushed the automation/sync-from-staging branch from f7432ca to 86c5d0c Compare May 31, 2026 08:24
@DaivdYuan DaivdYuan changed the title Sync approved changes from OpenWAM-staging (df98c20) Sync approved changes from OpenWAM-staging (099f6d9) May 31, 2026
@DaivdYuan
DaivdYuan marked this pull request as ready for review May 31, 2026 08:25
@DaivdYuan
DaivdYuan requested a review from Heng14 May 31, 2026 08:25
@DaivdYuan
DaivdYuan force-pushed the automation/sync-from-staging branch from 86c5d0c to 7d368f9 Compare June 2, 2026 20:09
@DaivdYuan DaivdYuan changed the title Sync approved changes from OpenWAM-staging (099f6d9) Sync approved changes from OpenWAM-staging (b219a4e) Jun 2, 2026
@DaivdYuan
DaivdYuan marked this pull request as draft June 2, 2026 20:09
@DaivdYuan
DaivdYuan marked this pull request as ready for review June 2, 2026 20:41
@DaivdYuan
DaivdYuan force-pushed the automation/sync-from-staging branch from 7d368f9 to be22bc0 Compare June 3, 2026 00:45
@DaivdYuan

Copy link
Copy Markdown
Owner Author

Updated this public sync branch to be22bc0, generated from OpenWAM-staging merge 1cf5c7b.

Addressed blockers:

  • Public workflows are now included in the sync branch, while the staging-only export workflow remains excluded.
  • Public PR checks now run; basic-pathways and minimal-package are both passing.
  • Removed internal-only checkpoint and camera deployment debug docs from the public snapshot.
  • Removed README links to missing notes/ and deployment/ trees and rewrote the deployment boundary doc.
  • Removed stale private/pending artifact manifest entries that referenced missing configs; ci_basic_sanity.py now fails if artifact config: paths are missing.
  • Updated public posttrain wrappers to default to included configs and WANDB_MODE=disabled.
  • Replaced the hardcoded private Hugging Face checkpoint downloader with a generic explicit --repo-id downloader.

Validated locally against the public branch:

  • blocker-pattern scan for the stale docs/config/telemetry references: clean
  • .github/workflows/ci.yml exists; .github/workflows/export-to-public.yml, docs/CHECKPOINT.md, and docs/camera_sync_deploy_issue.md are absent
  • OPEN_WAM_CI_NO_TORCH=1 python3 scripts/ci_basic_sanity.py passes

Automation note: the staging export workflow itself passed release checks but failed to push workflow files because OPENWAM_PUBLIC_REPO_TOKEN lacks workflow scope / Workflows read-write permission. I updated this branch manually with a local workflow-scoped GitHub token. The staging secret should be updated before the next automated export.

@DaivdYuan
DaivdYuan force-pushed the automation/sync-from-staging branch from be22bc0 to 514d93b Compare June 3, 2026 08:44
@DaivdYuan DaivdYuan changed the title Sync approved changes from OpenWAM-staging (b219a4e) Sync approved changes from OpenWAM-staging (0abb32a) Jun 3, 2026
@DaivdYuan

Copy link
Copy Markdown
Owner Author

Addressed the latest public-readiness findings in 514d93b, generated from OpenWAM-staging 0abb32a.

Fixes:

  • Removed open-wam-sanity and open-wam-sim-rollout from public console scripts because their backing implementations are not included in this public snapshot.
  • Deleted the stale CLI wrappers and updated docs so they no longer recommend those commands.
  • Updated scripts/ci_basic_sanity.py and .github/workflows/ci.yml to validate only installed public CLIs.
  • Fixed CI whitespace checking to compare base/head rather than a clean checkout with itself.
  • Cleaned the reported whitespace issues.
  • Fixed scripts/build_docs_site.py --output /tmp/... so repo-external output paths do not crash.
  • Made open_wam.models.video_backbone.config safe for minimal installs by lazy-loading runtime contracts that require Torch.

Validation, all with CUDA_VISIBLE_DEVICES='':

  • python3 -m compileall -q src scripts tests
  • python3 scripts/check_release_metadata.py
  • python3 scripts/validate_configs_static.py configs/experiments --quiet
  • uv lock --check
  • OPEN_WAM_CI_NO_TORCH=1 python3 scripts/ci_basic_sanity.py
  • python3 scripts/build_docs_site.py --output /tmp/openwam-docs-outside-repo-final
  • python3 scripts/build_docs_site.py --output .docs_site && uv run --extra docs mkdocs build --clean
  • source checkout dry runs for open-wam-train --help, open-wam-eval --help, open-wam-inspect-config --cfg ..., and selected open-wam-validate-config configs
  • fresh venv pip install .; imported package modules, confirmed Torch was not installed/importable in the minimal env, ran installed CLI help, confirmed removed CLIs are absent, validated selected configs, and ran installed open-wam-inspect-config
  • git diff --check 4b825dc642cb6eb9a060e54bf8d69288fbee4904
  • uv run --group dev --extra train ./scripts/check_public_release.sh: 27 tests passed; publication scans passed; gitleaks skipped because it is not installed locally
  • public checkout verification after branch update: git diff --check origin/main HEAD, OPEN_WAM_CI_NO_TORCH=1 python3 scripts/ci_basic_sanity.py, uv lock --check, and selected uv run open-wam-validate-config configs passed

Public PR checks are currently green: basic-pathways and minimal-package passed.

@DaivdYuan
DaivdYuan force-pushed the automation/sync-from-staging branch from 514d93b to 8fdc70f Compare June 3, 2026 09:43
@DaivdYuan DaivdYuan changed the title Sync approved changes from OpenWAM-staging (0abb32a) Sync approved changes from OpenWAM-staging (4fdf0f2) Jun 3, 2026
@DaivdYuan
DaivdYuan marked this pull request as draft June 3, 2026 09:43
@DaivdYuan

Copy link
Copy Markdown
Owner Author

Follow-up cleanup for the latest public-readiness review is now in 8fdc70f, generated from OpenWAM-staging 4fdf0f2.

Addressed:

  • Removed public-snapshot tests that referenced omitted RobotWin/post-latent/deprecated LIBERO configs: tests/test_lerobot_local_latent_dataset.py, tests/test_variant_pipeline.py, and the broken deprecated MoT visualization startup test.
  • Replaced tests/test_training_runtime.py with a public-safe runtime unit subset that does not require omitted configs or local datasets.
  • Updated tests/test_checkpoint_runtime.py to use exported public configs.
  • Removed broken/unneeded wrappers: scripts/run_train_backbone_only.sh, scripts/run_libero_mot_batch_visualization.py, and the deprecated MoT visualization implementation.
  • Kept the top-level deprecated MoT/Exact visualization wrappers fail-closed and updated their guidance to open-wam-eval with included configs instead of non-exported replacement scripts.
  • Cleaned README/reproducibility notes that pointed at fail-closed or placeholder config paths.
  • Added scripts/ci_basic_sanity.py coverage so tests fail CI if they reference experiment YAMLs not present under configs/experiments/.

Validation, all with CUDA_VISIBLE_DEVICES='':

  • Staging: python3 -m compileall -q src scripts tests
  • Staging: python3 scripts/check_release_metadata.py
  • Staging: python3 scripts/validate_configs_static.py configs/experiments --quiet
  • Staging: uv lock --check
  • Staging: OPEN_WAM_CI_NO_TORCH=1 python3 scripts/ci_basic_sanity.py
  • Staging: missing-path and stale-name scans over tests/docs/scripts/src/README are clean for the omitted configs/scripts named in review
  • Staging: uv run --group dev python -m pytest --collect-only -q collected cleanly
  • Staging: uv run --group dev python -m pytest -q passed: 345 passed, 1 skipped
  • Staging: docs staging and MkDocs build passed
  • Staging: source CLI dry runs and fresh minimal pip install . passed; removed CLIs are absent
  • Staging: uv run --group dev --extra train ./scripts/check_public_release.sh passed: 27 tests plus publication scans
  • Public exported checkout: git diff --check origin/main HEAD passed
  • Public exported checkout: OPEN_WAM_CI_NO_TORCH=1 python3 scripts/ci_basic_sanity.py passed
  • Public exported checkout: direct missing-path scan is clean
  • Public exported checkout: uv run --group dev --extra train python -m pytest -q passed: 345 passed, 1 skipped

Public PR checks are green: basic-pathways and minimal-package passed. The automated staging export also succeeded end-to-end this time.

@DaivdYuan
DaivdYuan force-pushed the automation/sync-from-staging branch from 8fdc70f to ee03f4f Compare June 3, 2026 10:11
@DaivdYuan DaivdYuan changed the title Sync approved changes from OpenWAM-staging (4fdf0f2) Sync approved changes from OpenWAM-staging (40f8ddb) Jun 3, 2026
@DaivdYuan

Copy link
Copy Markdown
Owner Author

Follow-up public-readiness cleanup landed in this PR at ee03f4f from staging 40f8ddb.

Changes addressed in this pass:

  • removed the stale checked-in fixture claim from configs/artifacts.sample.yaml / docs/artifacts.md; the sample artifact is now layout-only documentation
  • fixed docs that pointed at omitted paths, including the nonexistent scripts/eval.py implementation path
  • removed the stale LeRobot consortium refresh command that referenced omitted scripts/ and notes/ paths
  • removed duplicate unreferenced train wrapper scripts; documented the remaining checkpoint and LIBERO adapter utilities
  • added ci_basic_sanity.py guards for missing artifact source paths and known omitted public-snapshot references

Validation run from a clean exported public checkout at ee03f4f with CUDA_VISIBLE_DEVICES='':

  • GitHub public checks: basic-pathways passed, minimal-package passed
  • python3 -m compileall -q src scripts tests
  • OPEN_WAM_CI_NO_TORCH=1 python3 scripts/ci_basic_sanity.py
  • python3 scripts/check_release_metadata.py
  • python3 scripts/validate_configs_static.py configs/experiments --quiet
  • docs staging + uv run --extra docs mkdocs build --clean
  • uv lock --check
  • git diff --check origin/main..HEAD
  • clean minimal venv install: verified Torch is absent, package import works, and open-wam-validate-config, open-wam-inspect-config, open-wam-eval --help, open-wam-train --help run
  • full CPU pytest with train extra: 345 passed, 1 skipped
  • ./scripts/check_public_release.sh: 27 passed; local machine does not have gitleaks, so that scanner was skipped by the script

@DaivdYuan
DaivdYuan force-pushed the automation/sync-from-staging branch from ee03f4f to 305f91a Compare June 3, 2026 10:41
@DaivdYuan DaivdYuan changed the title Sync approved changes from OpenWAM-staging (40f8ddb) Sync approved changes from OpenWAM-staging (1046687) Jun 3, 2026
@DaivdYuan

Copy link
Copy Markdown
Owner Author

Second public-readiness cleanup landed in this PR at 305f91a from staging 1046687.

Changes addressed in this pass:

  • removed unused public root scripts: scripts/libero_exact_realtime_common.py, scripts/run_libero_exact_visualization.py, scripts/run_libero_mot_visualization.py
  • removed unused package legacy-forwarder helper src/open_wam/cli/_legacy_script.py
  • removed the obsolete fail-closed entrypoint test for the deleted scripts
  • tightened docs so open-wam-* commands are the stable public CLI surface and root scripts are only documented utilities or maintained launch wrappers
  • documented CPU-safe dry-run usage for the two remaining LIBERO shell launchers via OPEN_WAM_PRINT_TRAIN_ARGV=1
  • extended ci_basic_sanity.py to assert deleted public legacy scripts stay removed and remaining shell launchers pass bash -n

Audit notes:

  • no notes/ directory exists in the exported public snapshot
  • included experiment configs remain intentionally covered by config-loader/static-schema tests; no config was removed because these configs are part of method-family coverage
  • final root script inventory has no zero-reference files

Validation run from a clean exported public checkout at 305f91a with CUDA_VISIBLE_DEVICES='':

  • GitHub public checks: basic-pathways passed, minimal-package passed
  • python3 -m compileall -q src scripts tests
  • OPEN_WAM_CI_NO_TORCH=1 python3 scripts/ci_basic_sanity.py
  • python3 scripts/check_release_metadata.py
  • python3 scripts/validate_configs_static.py configs/experiments --quiet
  • docs staging + uv run --extra docs mkdocs build --clean
  • uv lock --check
  • git diff --check origin/main..HEAD
  • clean minimal venv install: verified Torch is absent, package import works, and open-wam-validate-config, open-wam-inspect-config, open-wam-eval --help, open-wam-train --help run
  • full CPU pytest with train extra: 343 passed, 1 skipped
  • ./scripts/check_public_release.sh: 27 passed; local machine does not have gitleaks, so that scanner was skipped by the script

@DaivdYuan
DaivdYuan marked this pull request as ready for review June 3, 2026 11:58
@DaivdYuan
DaivdYuan merged commit 6bd4483 into main Jun 7, 2026
2 checks passed
@DaivdYuan
DaivdYuan deleted the automation/sync-from-staging branch August 28, 2026 23:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants