Add resource_type/resource_id fields to HostInfo - #517
Conversation
Lets health-platform reports identify the resource represented by the reporting agent process: a plain host, the Cluster Agent, or a node agent running under a Kubernetes DaemonSet.
127074c to
2890509
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2890509dd3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| // ResourceType identifies the kind of resource this report's Host represents: | ||
| // "host" for a plain host agent, "cluster" for the Cluster Agent, or | ||
| // "deployment" for a node agent running under a Kubernetes DaemonSet. |
There was a problem hiding this comment.
For OpenTelemetry Collector reports—which this change explicitly intends to support—the schema documents mappings only for hosts, Cluster Agents, and node agents. Because resource_type is a free-form string, collector producers have no contract for either the type value or corresponding resource_id and may emit values the intake cannot interpret consistently. Add the collector mapping here, or clarify which existing mapping collectors must use.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Will restrict in a follow up
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
2 participants
Summary
resource_type/resource_idstring fields (4, 5) toHostInfoinhealthplatform.proto, so a health-platform report's host block identifies the resource represented by the impacted agent process: a plain host, the Cluster Agent, a node agent running under a Kubernetes DaemonSet, an otel collectorhealthplatform.pb.goaccordingly.