[Backport 7.85.x] fix(cws): read the Node.js record slot offset from the discovery struct - #57447
Open
dd-octo-sts[bot] wants to merge 1 commit into
Open
dd-octo-sts[bot] wants to merge 1 commit into
dd-octo-sts[bot] wants to merge 1 commit into
Conversation
…ct (#57373) ### What does this PR do? Reads the JSObject record slot offset from the per-thread `otel_thread_ctx_nodejs_v1` discovery struct, instead of hardcoding it, and drops the unused offset attributes from the test writer. ### Motivation The offset is 24 bytes on Node.js 22 and 32 on Node.js 23+, so the writer now publishes it per thread (DataDog/pprof-nodejs#421). Co-authored-by: daniel.mercier <daniel.mercier@datadoghq.com> (cherry picked from commit 8ccaee6) ___ Co-authored-by: Daniel Mercier <daniel.mercier@datadoghq.com>
dd-octo-sts
Bot
added
backport
bot
changelog/no-changelog
Contributor
Contributor
Author
Files inventory check summaryFile checks results against ancestor dddd723f: Results for datadog-agent_7.85.0~rc.2.git.10.b2b5fe9.pipeline.141968797-1_amd64.deb:No change detected Results for datadog-iot-agent_7.85.0~rc.2.git.10.b2b5fe9.pipeline.141968797-1_amd64.deb:No change detected |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 8ccaee6 from #57373.
What does this PR do?
Reads the JSObject record slot offset from the per-thread
otel_thread_ctx_nodejs_v1discovery struct, instead of hardcoding it, and drops the unused offset attributes from the test writer.Motivation
The offset is 24 bytes on Node.js 22 and 32 on Node.js 23+, so the writer now publishes it per thread (DataDog/pprof-nodejs#421).