ci: disable cloud metadata queries in integration tests - #666
Open
michael-richey wants to merge 1 commit into
Open
ci: disable cloud metadata queries in integration tests#666michael-richey wants to merge 1 commit into
michael-richey wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions integration-test workflow to prevent the Datadog Agent service container from querying cloud-provider metadata endpoints during test runs, reducing the risk of leaking host metadata via runner/service-container logs while keeping the APM trace intake path intact.
Changes:
- Set
DD_CLOUD_PROVIDER_METADATAto an empty list ("[]") for thedatadog-agentservice in the integration test workflow.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
michael-richey
marked this pull request as draft
August 13, 2026 19:43
michael-richey
marked this pull request as ready for review
August 13, 2026 19:45
michael-richey
marked this pull request as draft
August 13, 2026 19:52
michael-richey
marked this pull request as ready for review
August 13, 2026 19:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What this prevents
During service-container teardown, the Agent currently prints a UUID-shaped Azure cloud account identifier twice in the public workflow log. Based on the GitHub-hosted runner environment and the Agent message, this is the Azure subscription/account ID for the runner infrastructure, not a Datadog customer identifier.
The identifier is not a credential, token, or secret and does not grant access by itself, so the direct security severity is low. It is nevertheless a real production-infrastructure identifier that the integration tests do not need to discover or publish.
GitHub publishes service-container output during job teardown. Configuring the Agent with an empty cloud-provider metadata list prevents the metadata endpoint query that produces this output; the tests only require the Agent trace endpoint.
Validation
git diff --check