Skip to content

For Windows build, find where is Visual Studio - #381

Open
xlamorlette-datadog wants to merge 2 commits into
mainfrom
xlamorlette/fix-path-for-vs
Open

xlamorlette-datadog wants to merge 2 commits into
mainfrom
xlamorlette/fix-path-for-vs

Conversation

@xlamorlette-datadog

@xlamorlette-datadog xlamorlette-datadog commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Description

For Windows build CI jobs in GitHub, automatically locate where Visual Studio is installed.

Motivation

On September 28, the Windows arm64 runner in GitHub changed. This made the Windows build CI jobs fail, because the path for Visual Studio changed. Example:

The term 'C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\Common7\\Tools\\Launch-VsDevShell.ps1' is 
not recognized as the name of a cmdlet, function, script file, or operable program.

Note: the amd64 jobs were not impacted.

Validation

Successful Windows build jobs in this PR:

Jira ticket: IDMPL-1045 [C++ Tracer] [CI] Windows build broken on arm64

@pr-commenter

pr-commenter Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-10-02 13:45:04

Comparing candidate commit 699f55d in PR branch xlamorlette/fix-path-for-vs with baseline commit 7059aed in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@xlamorlette-datadog
xlamorlette-datadog marked this pull request as ready for review October 2, 2026 13:50
@xlamorlette-datadog
xlamorlette-datadog requested review from a team as code owners October 2, 2026 13:50
@xlamorlette-datadog
xlamorlette-datadog requested review from Anilm3 and removed request for a team October 2, 2026 13:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant