-
Notifications
You must be signed in to change notification settings - Fork 171
[Tracer] (Event Grid 2/5) Register outbound SDK calltargets #8912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pablomartinezbernardo
wants to merge
1
commit into
pmartinez/event-grid-contract-core
Choose a base branch
from
pmartinez/event-grid-calltargets
base: pmartinez/event-grid-contract-core
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
...nstrumentation/Azure/EventGrid/EventGridPublisherClientSendCloudEventsAsyncIntegration.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| // <copyright file="EventGridPublisherClientSendCloudEventsAsyncIntegration.cs" company="Datadog"> | ||
| // Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License. | ||
| // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc. | ||
| // </copyright> | ||
|
|
||
| #nullable enable | ||
|
|
||
| using System; | ||
| using System.ComponentModel; | ||
| using System.Threading; | ||
| using Datadog.Trace.ClrProfiler.CallTarget; | ||
| using Datadog.Trace.Configuration; | ||
|
|
||
| namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.Azure.EventGrid; | ||
|
|
||
| /// <summary> | ||
| /// Azure.Messaging.EventGrid.EventGridPublisherClient.SendEventsAsync calltarget instrumentation for IEnumerable<CloudEvent> | ||
| /// </summary> | ||
| [InstrumentMethod( | ||
| AssemblyName = "Azure.Messaging.EventGrid", | ||
| TypeName = "Azure.Messaging.EventGrid.EventGridPublisherClient", | ||
| MethodName = "SendEventsAsync", | ||
| ReturnTypeName = "System.Threading.Tasks.Task`1[Azure.Response]", | ||
| ParameterTypeNames = ["System.Collections.Generic.IEnumerable`1[Azure.Messaging.CloudEvent]", ClrNames.CancellationToken], | ||
| MinimumVersion = "4.0.0", | ||
| MaximumVersion = "5.*.*", | ||
| IntegrationName = nameof(IntegrationId.AzureEventGrid))] | ||
| [Browsable(false)] | ||
| [EditorBrowsable(EditorBrowsableState.Never)] | ||
| public sealed class EventGridPublisherClientSendCloudEventsAsyncIntegration | ||
| { | ||
| internal static CallTargetState OnMethodBegin<TTarget, TEvents>(TTarget instance, ref TEvents events, CancellationToken cancellationToken) | ||
| where TTarget : IEventGridPublisherClient | ||
| { | ||
| return EventGridCommon.CreateProducerSpan(instance, ref events, injectContext: true); | ||
| } | ||
|
|
||
| internal static TReturn OnAsyncMethodEnd<TTarget, TReturn>(TTarget instance, TReturn returnValue, Exception? exception, in CallTargetState state) | ||
| { | ||
| state.Scope?.DisposeWithException(exception); | ||
| return returnValue; | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the best duck-typing performance, you should add a generic constraint so we do the ducktyping upfront and we don't have to do it later on in downstream method calls. And then in the
EventGridCommon.CreateProducerSpanyou can do the same, where you have the generic constraintTTarget : IEventGridPublisherClientThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feedback applies to all the calltarget OnMethodBegin's where you call
EventGridCommon.CreateProducerSpan