Skip to content

feat(feature-flags): add InitializeAsync to manual API with CallTarget instrumentation - #9046

Closed
pavlokhrebto wants to merge 129 commits into
masterfrom
pavlo.khrebto/EX-2703/ffe-manual-api
Closed

pavlokhrebto wants to merge 129 commits into
masterfrom
pavlo.khrebto/EX-2703/ffe-manual-api

Conversation

@pavlokhrebto

@pavlokhrebto pavlokhrebto commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary of changes

Adds InitializeAsync to the Datadog.Trace.Manual feature flags API so that manual API users can trigger agentless delivery activation, just like OpenFeature users can.

This is PR 4 of a stacked PR series implementing agentless Feature Flags configuration delivery (FFL-2703), porting functionality from dd-trace-py#19331 and dd-trace-java#11892. Stacked on PR 1 #9040, PR 2 #9042, and PR 3 #9044.

Reason for change

.NET is the only SDK with a separate manual API (Datadog.Trace.Manual.FeatureFlagsSdk) that bypasses OpenFeature. With the new agentless default (PR 1), the agentless poller only starts at Activate(), which is called from InitializeAsync. The manual API had no InitializeAsync, so manual API users would be stuck with PROVIDER_NOT_READY forever unless they explicitly set remote_config.

Implementation details

  • Datadog.Trace.Manual/FeatureFlags/FeatureFlagsSdk.cs — adds InitializeAsync(CancellationToken) stub marked [Instrumented] that returns Task.CompletedTask
  • FeatureFlagsSdkInitializeAsyncIntegration.cs (new CallTarget) — intercepts the stub and calls TracerManager.Instance.FeatureFlags.InitializeAsync(cancellationToken), same pattern as the OpenFeature integration in PR 3
  • supported_calltargets.g.json — registers the new calltarget targeting Datadog.Trace.Manual version 3.31.0–3.*.*
  • InstrumentationDefinitions.g.cs (4 generated files) — auto-updated by the build to include the new integration in the allowlist

Test coverage

The InitializeAsync behavior is already tested in PR 3's FeatureFlagsModuleTests (activation, timeout, cancellation, no-delivery-start). This PR only adds the manual API stub and CallTarget wiring — no new tests needed since the underlying FeatureFlagsModule.InitializeAsync is unchanged.

Other details

Stacked PRs:

  • PR 1 #9040: Configuration keys, settings, and endpoint derivation
  • PR 2 #9042: UFC parser and agentless HTTP poller
  • PR 3 #9044: Module wiring and OpenFeature activation
  • PR 4 (this): Manual API activation

System tests: DataDog/system-tests#7496

@pavlokhrebto pavlokhrebto changed the title feat(feature-flags): add InitializeAsync to manual API with CallTarge… feat(feature-flags): add InitializeAsync to manual API with CallTarget instrumentation Aug 13, 2026
@pavlokhrebto pavlokhrebto added type:new-feature AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos feature_flags labels Aug 13, 2026
@pr-commenter

pr-commenter Bot commented Aug 13, 2026 •

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-09-16 09:58:03

Comparing candidate commit 871aeac in PR branch pavlo.khrebto/EX-2703/ffe-manual-api with baseline commit 11e96e7 in branch master.

📊 Benchmarking dashboard

Found 1 performance improvements and 0 performance regressions! Performance is the same for 71 metrics, 0 unstable metrics, 65 known flaky benchmarks, 61 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net6.0

  • 🟩 throughput [+7699.106op/s; +8646.514op/s] or [+5.230%; +5.874%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-6425.225op/s; -5861.058op/s] or [-7.618%; -6.949%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • 🟥 throughput [-9272.186op/s; -8178.827op/s] or [-9.428%; -8.316%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 allocated_mem [+1.573KB; +1.573KB] or [+47.789%; +47.804%]
  • 🟥 execution_time [+311.088ms; +314.218ms] or [+154.373%; +155.926%]
  • 🟥 throughput [-60.089op/s; -55.641op/s] or [-10.811%; -10.011%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 allocated_mem [+1.012KB; +1.012KB] or [+37.524%; +37.537%]
  • 🟥 execution_time [+375.596ms; +377.894ms] or [+296.744%; +298.559%]
  • 🟩 throughput [+66.213op/s; +70.010op/s] or [+8.730%; +9.231%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 allocated_mem [+1.088KB; +1.088KB] or [+40.343%; +40.355%]
  • 🟥 execution_time [+392.292ms; +396.173ms] or [+347.164%; +350.598%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+4.734KB; +4.734KB] or [+99.652%; +99.667%]
  • 🟥 throughput [-60463.183op/s; -60004.165op/s] or [-47.043%; -46.686%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+3.856KB; +3.856KB] or [+81.546%; +81.558%]
  • 🟩 execution_time [-16.205ms; -12.020ms] or [-7.568%; -5.614%]
  • 🟥 throughput [-61496.539op/s; -58734.135op/s] or [-44.889%; -42.873%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+4.583KB; +4.584KB] or [+99.120%; +99.133%]
  • 🟥 throughput [-49317.411op/s; -47034.282op/s] or [-44.589%; -42.524%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.356KB; +1.356KB] or [+109.716%; +109.731%]
  • 🟥 throughput [-288552.083op/s; -284910.834op/s] or [-29.463%; -29.091%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+519 bytes; +520 bytes] or [+42.477%; +42.486%]
  • 🟩 execution_time [-25.589ms; -20.733ms] or [-11.412%; -9.246%]
  • 🟥 throughput [-105301.172op/s; -82933.781op/s] or [-11.249%; -8.860%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.320KB; +1.320KB] or [+109.261%; +109.277%]
  • 🟥 throughput [-174630.398op/s; -157004.131op/s] or [-25.091%; -22.558%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472

  • 🟥 allocated_mem [+3.378KB; +3.378KB] or [+89.003%; +89.017%]
  • 🟥 throughput [-72618.297op/s; -71849.717op/s] or [-48.871%; -48.354%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟥 allocated_mem [+3.336KB; +3.336KB] or [+88.150%; +88.161%]
  • 🟥 throughput [-74842.407op/s; -71948.716op/s] or [-47.621%; -45.780%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+3.264KB; +3.264KB] or [+88.493%; +88.506%]
  • 🟥 throughput [-55657.044op/s; -53024.170op/s] or [-44.338%; -42.241%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 throughput [+234070.454op/s; +258514.034op/s] or [+7.805%; +8.620%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-18.360ms; -14.010ms] or [-8.463%; -6.458%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟩 allocated_mem [-13.759KB; -13.756KB] or [-42.324%; -42.316%]
  • 🟥 execution_time [+300.788ms; +301.900ms] or [+150.294%; +150.849%]
  • 🟩 throughput [+1005.757op/s; +1025.419op/s] or [+11.108%; +11.326%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • 🟩 allocated_mem [-13.722KB; -13.718KB] or [-42.341%; -42.329%]
  • 🟥 execution_time [+299.694ms; +302.857ms] or [+151.136%; +152.732%]
  • 🟩 throughput [+2258.348op/s; +2467.407op/s] or [+17.273%; +18.872%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • 🟩 allocated_mem [-13.722KB; -13.718KB] or [-42.341%; -42.329%]
  • 🟥 execution_time [+299.826ms; +302.303ms] or [+151.029%; +152.277%]
  • 🟩 throughput [+1743.085op/s; +1868.625op/s] or [+16.829%; +18.041%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+295.861ms; +297.289ms] or [+145.315%; +146.017%]
  • 🟩 throughput [+568.931op/s; +587.993op/s] or [+15.083%; +15.588%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+297.254ms; +299.053ms] or [+145.317%; +146.196%]
  • 🟩 throughput [+2782.488op/s; +2827.632op/s] or [+40.424%; +41.080%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+301.030ms; +302.370ms] or [+150.455%; +151.124%]
  • 🟩 throughput [+1359.192op/s; +1396.374op/s] or [+26.979%; +27.717%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472

  • 🟩 execution_time [-147.620µs; -143.688µs] or [-30.308%; -29.501%]
  • 🟩 throughput [+863.452op/s; +889.465op/s] or [+42.054%; +43.321%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0

  • 🟩 execution_time [-134.440µs; -107.710µs] or [-30.834%; -24.703%]
  • 🟩 throughput [+814.374op/s; +937.928op/s] or [+35.406%; +40.777%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1

  • 🟩 execution_time [-141.304µs; -119.272µs] or [-30.275%; -25.554%]
  • 🟩 throughput [+764.733op/s; +848.248op/s] or [+35.302%; +39.157%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472

  • 🟩 execution_time [-128.238µs; -124.074µs] or [-34.623%; -33.499%]
  • 🟩 throughput [+1371.931op/s; +1419.752op/s] or [+50.810%; +52.581%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟩 execution_time [-80.871µs; -53.295µs] or [-25.818%; -17.014%]
  • 🟩 throughput [+752.906op/s; +1026.178op/s] or [+23.470%; +31.989%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1

  • 🟩 execution_time [-137.104µs; -114.632µs] or [-37.506%; -31.359%]
  • 🟩 throughput [+1316.888op/s; +1457.664op/s] or [+47.258%; +52.310%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+299.881ms; +300.671ms] or [+149.672%; +150.065%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • unstable execution_time [+324.093ms; +380.694ms] or [+352.141%; +413.640%]
  • 🟩 throughput [+974.917op/s; +1161.748op/s] or [+8.011%; +9.546%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • unstable execution_time [+240.490ms; +307.110ms] or [+182.602%; +233.186%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 allocated_mem [+2.834KB; +2.839KB] or [+5.035%; +5.044%]
  • unstable execution_time [+273.746ms; +325.468ms] or [+125.866%; +149.647%]
  • 🟥 throughput [-595.028op/s; -542.120op/s] or [-53.915%; -49.121%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [+207.397ms; +340.624ms] or [+88.384%; +145.160%]
  • 🟥 throughput [-666.553op/s; -583.089op/s] or [-44.459%; -38.892%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+326.248ms; +336.868ms] or [+195.134%; +201.486%]
  • 🟥 throughput [-395.416op/s; -358.202op/s] or [-27.532%; -24.941%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 execution_time [+302.279ms; +303.665ms] or [+152.222%; +152.920%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 execution_time [+302.859ms; +305.215ms] or [+151.763%; +152.944%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 execution_time [+300.695ms; +304.796ms] or [+151.057%; +153.117%]
  • 🟩 throughput [+32315.683op/s; +41873.676op/s] or [+6.807%; +8.821%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 execution_time [+302.680ms; +304.843ms] or [+151.996%; +153.082%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • 🟥 execution_time [+298.843ms; +300.765ms] or [+147.765%; +148.715%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 execution_time [+303.316ms; +307.123ms] or [+153.734%; +155.663%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 execution_time [+298.109ms; +300.743ms] or [+149.624%; +150.946%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 execution_time [+299.397ms; +313.390ms] or [+149.222%; +156.196%]
  • 🟩 throughput [+30792.221op/s; +43383.163op/s] or [+6.114%; +8.614%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 execution_time [+299.976ms; +307.388ms] or [+149.236%; +152.923%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • 🟩 execution_time [-16.450ms; -12.754ms] or [-7.649%; -5.930%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1

  • 🟩 throughput [+15380.911op/s; +21065.204op/s] or [+5.614%; +7.689%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472

  • unstable execution_time [+10.446µs; +55.437µs] or [+2.580%; +13.693%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-24.904KB; -24.881KB] or [-9.085%; -9.076%]
  • unstable execution_time [-37.242µs; +20.192µs] or [-7.361%; +3.991%]
  • unstable throughput [-69.794op/s; +133.591op/s] or [-3.483%; +6.666%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • unstable execution_time [-66.878µs; -1.795µs] or [-11.589%; -0.311%]
  • unstable throughput [+28.399op/s; +215.369op/s] or [+1.622%; +12.304%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • unstable execution_time [+8.701µs; +13.346µs] or [+20.566%; +31.546%]
  • 🟥 throughput [-5763.775op/s; -3907.928op/s] or [-24.264%; -16.451%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-14.525µs; -6.513µs] or [-22.535%; -10.105%]
  • unstable throughput [+1697.552op/s; +3445.792op/s] or [+10.415%; +21.141%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+303.749ms; +305.859ms] or [+153.531%; +154.598%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+299.086ms; +304.097ms] or [+152.234%; +154.784%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+301.224ms; +303.777ms] or [+150.800%; +152.078%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472

  • 🟥 throughput [-22934.695op/s; -20170.791op/s] or [-6.349%; -5.584%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • 🟩 throughput [+29336.750op/s; +36118.016op/s] or [+5.553%; +6.836%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+296.481ms; +298.380ms] or [+147.769%; +148.715%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+301.715ms; +303.498ms] or [+151.507%; +152.402%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+302.004ms; +305.699ms] or [+153.157%; +155.031%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+300.087ms; +300.900ms] or [+149.685%; +150.091%]
  • 🟩 throughput [+61075932.941op/s; +61397939.333op/s] or [+44.479%; +44.714%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • unstable execution_time [+268.561ms; +345.738ms] or [+334.003%; +429.986%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+298.775ms; +299.889ms] or [+149.022%; +149.578%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • 🟩 throughput [+81610.498op/s; +92518.215op/s] or [+7.620%; +8.638%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • 🟩 throughput [+69549.000op/s; +99787.420op/s] or [+5.383%; +7.724%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • 🟩 throughput [+71875.707op/s; +79467.737op/s] or [+7.138%; +7.892%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 throughput [+34460.485op/s; +43342.271op/s] or [+6.257%; +7.870%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented Aug 14, 2026 •

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (9046) and master.

✅ No regressions detected

📄 View the full report (charts + all metrics) →

@pavlokhrebto
pavlokhrebto requested review from link04 and removed request for a team September 7, 2026 11:21
Comment thread tracer/src/Datadog.Trace.Manual/FeatureFlags/FeatureFlagsSdk.cs Outdated
Comment thread tracer/src/Datadog.Trace.Manual/FeatureFlags/FeatureFlagsSdk.cs Outdated
@aarsilv

aarsilv commented Sep 9, 2026

Copy link
Copy Markdown

🤖 Comment from Claude working with Aaron Silverman:

[P3] Two description tweaks, both about who is actually affected.

The legacy key is a second escape hatch. The description says manual API users "would be stuck
with PROVIDER_NOT_READY forever unless they explicitly set remote_config". There is another path:
FeatureFlagsSettings.cs:75-76 grandfathers DD_EXPERIMENTAL_FLAGGING_PROVIDER_ENABLED=true onto
remote_config as well (excerpt, from the enabled switch):

null when legacyEnabled is not null => legacyEnabled.Value
    ? new(FeatureFlagsSource.RemoteConfig, RemoteConfigSourceName)
    : new(FeatureFlagsSource.Offline, OfflineSourceName),
_ => new(FeatureFlagsSource.Agentless, AgentlessSourceName),

So existing adopters running the legacy key keep remote_config and are unaffected. What is left is
new adopters and anyone moving to DD_FEATURE_FLAGS_ENABLED — and of those, only the ones without a
usable agentless setup actually get stuck. Worth stating, because it narrows the blast radius, and it
is the same mechanism that keeps FeatureFlagsTests green today.

"No new tests needed" is right about the attribute pairing and not about the wiring. The pairing
is genuinely guarded — see my comment on the CallTarget. The return-value substitution is not.

Base automatically changed from pavlo.khrebto/EX-2703/ffe-module-wiring to master September 14, 2026 10:11
@pavlokhrebto

Copy link
Copy Markdown
Contributor Author

closed in favor of #9260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos feature_flags type:new-feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants