Skip to content

[FeatureFlags] Stop serving flags removed from a modified Remote Configuration file - #9304

Merged
pavlokhrebto merged 1 commit into
masterfrom
pavlo.khrebto/FFL-3338/ffe-rcm-replace-modified-config
Sep 24, 2026
Merged

[FeatureFlags] Stop serving flags removed from a modified Remote Configuration file#9304
pavlokhrebto merged 1 commit into
masterfrom
pavlo.khrebto/FFL-3338/ffe-rcm-replace-modified-config

Conversation

@pavlokhrebto

@pavlokhrebto pavlokhrebto commented Sep 24, 2026 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Contributor

Summary of changes

FfeProduct.UpdateFromRcm replaces the stored version of a flags file when a modified version arrives, instead of appending it.

Reason for change

Fixes #9301. When a flag was disabled or removed for an environment, a running process kept evaluating it with its last value until restart. Rule and variant changes propagated; only removals were lost.

A modified file arrives under the path it already has, and never in the removed set, so FfeProduct kept both the old and the new version. The module merges all stored versions, and a merge only adds or overwrites keys, so a flag missing from the new version was still served from the old one. The stored list also grew by one full copy of the flags file on every update, for the life of the process.

Only the Remote Configuration source is affected. The agentless source replaces the whole configuration on every update.

Origin

  • #7896 made FfeProduct append a modified file instead of replacing it. Removals still worked, because the module used only the last entry, so the duplicates were only a memory leak.
  • #8074 changed the module to merge all entries. This is where removals broke.
  • #8616 rewrote FlagCollection with the same add-or-overwrite merge, so the behaviour did not change.

Implementation details

Remove any entry stored under the incoming path before adding the new one, as suggested in the issue. Go does the equivalent: each update replaces the provider's configuration.

Test coverage

  • UpdateRemoteConfig_WhenAModifiedFileDropsAFlag_TheFlagIsNoLongerFound: v1 of a file holds two flags, v2 under the same path holds one. The dropped flag returns FLAG_NOT_FOUND, and the kept flag still resolves.
  • UpdateFromRcm_WhenTheSameFileIsModifiedRepeatedly_HoldsOneVersionOfIt: three updates to one path leave exactly one stored version.

Other details

Jira: FFL-3338

The issue also reports update events arriving as ProviderReady with a null provider name. That was already fixed by #9044, which emits ProviderConfigurationChanged with the provider name, and shipped in Datadog.FeatureFlags.OpenFeature 2.3.1.

@pavlokhrebto pavlokhrebto changed the title [FeatureFlags] Replace a modified Remote Configuration flags file ins… [FeatureFlags] Stop serving flags removed from a modified Remote Configuration file Sep 24, 2026
@pr-commenter

pr-commenter Bot commented Sep 24, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-09-24 09:29:22

Comparing candidate commit 911256c in PR branch pavlo.khrebto/FFL-3338/ffe-rcm-replace-modified-config with baseline commit 1e5948d in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 11 performance regressions! Performance is the same for 61 metrics, 0 unstable metrics, 71 known flaky benchmarks, 55 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net472

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+9.290%; +9.300%]
  • 🟥 throughput [-30938.347op/s; -28254.073op/s] or [-8.714%; -7.958%]

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+8.939%; +8.950%]

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+9.009%; +9.021%]
  • 🟥 throughput [-41264.790op/s; -32128.004op/s] or [-10.200%; -7.941%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net472

  • 🟥 allocated_mem [+296 bytes; +297 bytes] or [+10.196%; +10.207%]
  • 🟥 throughput [-9666.469op/s; -9339.499op/s] or [-11.035%; -10.662%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net6.0

  • 🟥 allocated_mem [+191 bytes; +192 bytes] or [+9.052%; +9.064%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync netcoreapp3.1

  • 🟥 allocated_mem [+191 bytes; +192 bytes] or [+7.267%; +7.279%]
  • 🟥 throughput [-12152.546op/s; -10926.339op/s] or [-9.644%; -8.671%]

scenario:Benchmarks.Trace.NLogBenchmark.EnrichedLog net472

  • 🟥 throughput [-7844.345op/s; -6934.125op/s] or [-6.009%; -5.312%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-11122.283op/s; -10669.811op/s] or [-13.188%; -12.651%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0

  • 🟥 throughput [-10686.561op/s; -8363.614op/s] or [-8.982%; -7.030%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • 🟥 throughput [-13520.125op/s; -12027.682op/s] or [-13.747%; -12.229%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 allocated_mem [+1.573KB; +1.573KB] or [+47.789%; +47.804%]
  • 🟥 execution_time [+305.962ms; +308.310ms] or [+151.829%; +152.995%]
  • 🟥 throughput [-54.486op/s; -50.494op/s] or [-9.803%; -9.085%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 allocated_mem [+1.012KB; +1.012KB] or [+37.524%; +37.537%]
  • 🟥 execution_time [+375.298ms; +376.545ms] or [+296.509%; +297.494%]
  • 🟩 throughput [+68.371op/s; +70.483op/s] or [+9.014%; +9.293%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 allocated_mem [+1.090KB; +1.090KB] or [+40.417%; +40.429%]
  • 🟥 execution_time [+400.555ms; +402.415ms] or [+354.476%; +356.122%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+4.749KB; +4.750KB] or [+99.987%; +100.003%]
  • 🟥 throughput [-61015.693op/s; -60637.055op/s] or [-47.473%; -47.179%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+3.872KB; +3.872KB] or [+81.884%; +81.895%]
  • 🟩 execution_time [-16.039ms; -11.866ms] or [-7.491%; -5.542%]
  • 🟥 throughput [-61733.262op/s; -58965.051op/s] or [-45.062%; -43.041%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+4.600KB; +4.600KB] or [+99.468%; +99.481%]
  • 🟥 throughput [-48863.121op/s; -46612.066op/s] or [-44.178%; -42.143%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.372KB; +1.372KB] or [+111.007%; +111.023%]
  • 🟥 throughput [-306381.658op/s; -299177.223op/s] or [-31.283%; -30.547%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+535 bytes; +536 bytes] or [+43.787%; +43.796%]
  • 🟩 execution_time [-26.436ms; -21.595ms] or [-11.789%; -9.630%]
  • 🟥 throughput [-117944.631op/s; -94357.684op/s] or [-12.600%; -10.080%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.336KB; +1.336KB] or [+110.585%; +110.599%]
  • 🟥 throughput [-169246.600op/s; -153404.985op/s] or [-24.317%; -22.041%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472

  • 🟥 allocated_mem [+3.378KB; +3.378KB] or [+89.003%; +89.017%]
  • 🟥 throughput [-73706.711op/s; -72894.219op/s] or [-49.604%; -49.057%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟥 allocated_mem [+3.336KB; +3.336KB] or [+88.150%; +88.161%]
  • 🟥 throughput [-75003.896op/s; -72101.002op/s] or [-47.724%; -45.877%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+3.264KB; +3.264KB] or [+88.493%; +88.506%]
  • 🟥 throughput [-56893.116op/s; -54256.529op/s] or [-45.323%; -43.222%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 throughput [+222048.579op/s; +266628.817op/s] or [+7.404%; +8.891%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-18.782ms; -14.195ms] or [-8.658%; -6.543%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟩 allocated_mem [-13.759KB; -13.757KB] or [-42.326%; -42.318%]
  • 🟥 execution_time [+300.245ms; +300.983ms] or [+150.022%; +150.391%]
  • 🟩 throughput [+1029.453op/s; +1056.635op/s] or [+11.370%; +11.670%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • 🟩 allocated_mem [-13.722KB; -13.718KB] or [-42.341%; -42.329%]
  • 🟥 execution_time [+299.730ms; +302.877ms] or [+151.155%; +152.742%]
  • 🟩 throughput [+2288.676op/s; +2499.400op/s] or [+17.505%; +19.117%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • 🟩 allocated_mem [-13.722KB; -13.718KB] or [-42.341%; -42.329%]
  • 🟥 execution_time [+300.899ms; +303.251ms] or [+151.569%; +152.754%]
  • 🟩 throughput [+1842.378op/s; +1975.685op/s] or [+17.787%; +19.074%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+296.602ms; +297.705ms] or [+145.679%; +146.221%]
  • 🟩 throughput [+576.790op/s; +595.430op/s] or [+15.291%; +15.785%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+296.291ms; +297.549ms] or [+144.845%; +145.461%]
  • 🟩 throughput [+2768.450op/s; +2863.037op/s] or [+40.220%; +41.595%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+302.002ms; +302.724ms] or [+150.940%; +151.301%]
  • 🟩 throughput [+1363.332op/s; +1387.597op/s] or [+27.061%; +27.543%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472

  • 🟩 execution_time [-145.464µs; -141.284µs] or [-29.866%; -29.008%]
  • 🟩 throughput [+842.957op/s; +871.390op/s] or [+41.056%; +42.441%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0

  • 🟩 execution_time [-135.477µs; -108.833µs] or [-31.072%; -24.961%]
  • 🟩 throughput [+825.719op/s; +947.548op/s] or [+35.899%; +41.196%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1

  • 🟩 execution_time [-136.495µs; -108.961µs] or [-29.245%; -23.345%]
  • 🟩 throughput [+691.055op/s; +821.902op/s] or [+31.900%; +37.941%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472

  • 🟩 execution_time [-127.094µs; -122.122µs] or [-34.315%; -32.972%]
  • 🟩 throughput [+1339.848op/s; +1403.165op/s] or [+49.622%; +51.967%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟩 execution_time [-96.947µs; -73.176µs] or [-30.950%; -23.361%]
  • 🟩 throughput [+1073.842op/s; +1281.795op/s] or [+33.475%; +39.957%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1

  • 🟩 execution_time [-138.052µs; -115.656µs] or [-37.766%; -31.639%]
  • 🟩 throughput [+1335.128op/s; +1472.378op/s] or [+47.912%; +52.838%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+299.936ms; +300.671ms] or [+149.699%; +150.066%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • unstable execution_time [+329.577ms; +389.529ms] or [+358.099%; +423.240%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • unstable execution_time [+183.885ms; +253.478ms] or [+139.622%; +192.463%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • unstable execution_time [+278.356ms; +332.752ms] or [+127.985%; +152.996%]
  • 🟥 throughput [-543.367op/s; -498.612op/s] or [-49.234%; -45.179%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [+207.412ms; +340.690ms] or [+88.390%; +145.188%]
  • 🟥 throughput [-679.242op/s; -595.439op/s] or [-45.306%; -39.716%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 allocated_mem [+2.305KB; +2.308KB] or [+5.442%; +5.450%]
  • 🟥 execution_time [+334.631ms; +346.741ms] or [+200.148%; +207.391%]
  • 🟥 throughput [-402.366op/s; -363.575op/s] or [-28.016%; -25.315%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1

  • unstable throughput [-8.071op/s; +85.533op/s] or [-1.506%; +15.965%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 allocated_mem [+88 bytes; +89 bytes] or [+11.094%; +11.104%]
  • 🟥 execution_time [+300.362ms; +301.810ms] or [+151.256%; +151.986%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+11.101%; +11.112%]
  • 🟥 execution_time [+299.868ms; +301.969ms] or [+150.264%; +151.317%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+11.101%; +11.112%]
  • 🟥 execution_time [+301.635ms; +304.749ms] or [+151.528%; +153.093%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+10.235%; +10.247%]
  • 🟥 execution_time [+301.334ms; +303.305ms] or [+151.320%; +152.310%]
  • 🟥 throughput [-19193.772op/s; -17239.754op/s] or [-6.430%; -5.776%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+11.451%; +11.465%]
  • 🟥 execution_time [+300.330ms; +302.354ms] or [+148.500%; +149.501%]
  • 🟥 throughput [-56072.824op/s; -50762.188op/s] or [-9.034%; -8.179%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+10.469%; +10.481%]
  • 🟥 execution_time [+303.626ms; +307.689ms] or [+153.891%; +155.950%]
  • 🟥 throughput [-41703.904op/s; -31993.633op/s] or [-9.006%; -6.909%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 allocated_mem [+88 bytes; +89 bytes] or [+10.268%; +10.280%]
  • 🟥 execution_time [+301.630ms; +304.041ms] or [+151.391%; +152.601%]
  • 🟥 throughput [-38940.772op/s; -32375.429op/s] or [-10.102%; -8.399%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+9.730%; +9.743%]
  • 🟥 execution_time [+299.820ms; +302.946ms] or [+149.433%; +150.991%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+9.730%; +9.743%]
  • 🟥 execution_time [+300.359ms; +303.867ms] or [+149.426%; +151.171%]
  • 🟥 throughput [-37610.579op/s; -32106.028op/s] or [-8.903%; -7.600%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472

  • 🟥 allocated_mem [+88 bytes; +89 bytes] or [+5.504%; +5.513%]
  • 🟥 throughput [-20820.022op/s; -18867.913op/s] or [-8.372%; -7.587%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+5.160%; +5.169%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+5.136%; +5.148%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472

  • unstable execution_time [+9.171µs; +54.644µs] or [+2.265%; +13.497%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-17.669KB; -17.646KB] or [-6.445%; -6.437%]
  • unstable execution_time [-23.544µs; +34.619µs] or [-4.653%; +6.842%]
  • unstable throughput [-124.661op/s; +77.951op/s] or [-6.221%; +3.890%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • unstable execution_time [+46.196µs; +214.983µs] or [+8.005%; +37.255%]
  • unstable throughput [-304.795op/s; -28.898op/s] or [-17.413%; -1.651%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • unstable execution_time [+5.099µs; +9.760µs] or [+12.051%; +23.070%]
  • 🟥 throughput [-4394.061op/s; -2538.382op/s] or [-18.498%; -10.686%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-13.623µs; -4.987µs] or [-21.136%; -7.737%]
  • unstable throughput [+1346.913op/s; +3221.778op/s] or [+8.264%; +19.767%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+300.868ms; +302.774ms] or [+152.076%; +153.039%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+304.772ms; +308.776ms] or [+155.128%; +157.166%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+299.691ms; +301.927ms] or [+150.032%; +151.152%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+8.432%; +8.443%]
  • 🟥 throughput [-49250.711op/s; -47395.589op/s] or [-13.634%; -13.120%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+8.456%; +8.467%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+8.456%; +8.466%]
  • 🟥 throughput [-37212.360op/s; -28463.457op/s] or [-8.807%; -6.736%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+297.929ms; +300.308ms] or [+148.491%; +149.676%]
  • 🟥 throughput [-11649.473op/s; -10437.246op/s] or [-7.692%; -6.892%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • 🟥 allocated_mem [+88 bytes; +88 bytes] or [+5.502%; +5.512%]
  • 🟥 execution_time [+302.379ms; +305.192ms] or [+151.840%; +153.253%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+5.333%; +5.343%]
  • 🟥 execution_time [+305.466ms; +308.510ms] or [+154.912%; +156.457%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+299.239ms; +300.086ms] or [+149.262%; +149.685%]
  • 🟩 throughput [+61070972.217op/s; +61403703.740op/s] or [+44.476%; +44.718%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • 🟥 execution_time [+413.732ms; +418.480ms] or [+514.549%; +520.454%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+299.021ms; +300.085ms] or [+149.145%; +149.676%]
  • 🟩 throughput [+17720902.355op/s; +18700038.277op/s] or [+7.849%; +8.283%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472

  • 🟥 throughput [-55095.373op/s; -47211.063op/s] or [-6.149%; -5.269%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472

  • 🟥 throughput [-88053.459op/s; -83004.447op/s] or [-8.060%; -7.598%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 throughput [+33910.820op/s; +39623.387op/s] or [+6.158%; +7.195%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+14.421%; +14.433%]
  • 🟥 throughput [-95271.081op/s; -91789.869op/s] or [-13.943%; -13.434%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+13.576%; +13.589%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+13.576%; +13.587%]
  • 🟥 throughput [-84081.598op/s; -69390.476op/s] or [-11.740%; -9.689%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

@pavlokhrebto pavlokhrebto added type:bug AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos feature_flags labels Sep 24, 2026
@pavlokhrebto
pavlokhrebto marked this pull request as ready for review September 24, 2026 09:50
@pavlokhrebto
pavlokhrebto requested review from a team as code owners September 24, 2026 09:51
@pavlokhrebto
pavlokhrebto requested review from andrewlock, leoromanovsky and vjfridge and removed request for a team September 24, 2026 09:51
leoromanovsky
leoromanovsky approved these changes Sep 24, 2026
View reviewed changes

@leoromanovsky leoromanovsky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you nailed it.

@pavlokhrebto
pavlokhrebto merged commit 1b0e3f0 into master Sep 24, 2026
158 of 159 checks passed
@pavlokhrebto
pavlokhrebto deleted the pavlo.khrebto/FFL-3338/ffe-rcm-replace-modified-config branch September 24, 2026 13:39
@github-actions github-actions Bot added this to the vNext-v3 milestone Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leoromanovsky leoromanovsky leoromanovsky approved these changes
@vjfridge vjfridge Awaiting requested review from vjfridge vjfridge is a code owner automatically assigned from DataDog/feature-flagging-and-experimentation-sdk
@andrewlock andrewlock Awaiting requested review from andrewlock

Assignees

No one assigned

Labels

AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos feature_flags identified-by:customer type:bug

Projects

None yet

Milestone

vNext-v3

Development

Successfully merging this pull request may close these issues.

[BUG]: Feature flags: disabling/removing a flag is ignored until restart (FfeProduct appends modified RC configs instead of replacing)

3 participants

@pavlokhrebto @leoromanovsky @andrewlock