Skip to content

Update libdatadog and adapt rate limiter APIs - #4259

Merged
bwoebi merged 3 commits into
masterfrom
glopes/new-limiter
Oct 2, 2026
Merged

bwoebi merged 3 commits into
masterfrom
glopes/new-limiter

Conversation

@cataphract

Copy link
Copy Markdown
Contributor

Description

Replace the removed limiter abstractions with a local wrapper and pass the new granularity arguments.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

Replace the removed limiter abstractions with a local wrapper and pass the
new granularity arguments.
@cataphract
cataphract requested review from a team as code owners October 1, 2026 09:54
@cataphract
cataphract requested review from typotter and vjfridge and removed request for a team October 1, 2026 09:54
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-01T09:56:33.736721Z d7e7c15 PR opened
🔒 Security Review ✅ Completed 2026-10-01T09:57:42.563481Z d7e7c15 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 68.38% (-0.04%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b9fa8af | Docs | View more details | Give us feedback!

@pr-commenter

pr-commenter Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Benchmarks [ tracer ]

Benchmark execution time: 2026-10-02 01:24:18

Comparing candidate commit b9fa8af in PR branch glopes/new-limiter with baseline commit c6e46bc in branch master.

📊 Benchmarking dashboard

Found 19 performance improvements and 0 performance regressions! Performance is the same for 174 metrics, 1 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:ContextPropagationBench/benchInject64Bit-opcache

  • 🟩 execution_time [-15.095µs; -14.863µs] or [-87.525%; -86.174%]

scenario:PDOBench/benchPDOOverhead

  • 🟩 execution_time [-32.937µs; -28.471µs] or [-10.128%; -8.755%]

scenario:PDOBench/benchPDOOverhead-opcache

  • 🟩 execution_time [-30.088µs; -24.639µs] or [-9.470%; -7.755%]

scenario:PDOBench/benchPDOOverheadWithDBM

  • 🟩 execution_time [-35.222µs; -29.925µs] or [-10.775%; -9.154%]

scenario:PDOBench/benchPDOOverheadWithDBM-opcache

  • 🟩 execution_time [-33.364µs; -28.376µs] or [-10.457%; -8.894%]

scenario:PHPRedisBench/benchRedisOverhead

  • 🟩 execution_time [-160.457µs; -129.812µs] or [-12.093%; -9.784%]

scenario:PHPRedisBench/benchRedisOverhead-opcache

  • 🟩 execution_time [-162.565µs; -129.539µs] or [-12.003%; -9.565%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟩 execution_time [-16.006µs; -15.609µs] or [-92.421%; -90.124%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1-opcache

  • 🟩 execution_time [-15.099µs; -14.897µs] or [-90.870%; -89.653%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟩 execution_time [-15.914µs; -15.655µs] or [-92.356%; -90.853%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2-opcache

  • 🟩 execution_time [-15.238µs; -15.000µs] or [-90.720%; -89.301%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟩 execution_time [-16.080µs; -15.788µs] or [-92.453%; -90.773%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3-opcache

  • 🟩 execution_time [-14.992µs; -14.823µs] or [-90.748%; -89.725%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟩 execution_time [-16.109µs; -15.884µs] or [-92.362%; -91.070%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4-opcache

  • 🟩 execution_time [-15.060µs; -14.830µs] or [-90.648%; -89.263%]

scenario:SpanBench/benchOpenTelemetryAPI

  • 🟩 execution_time [-483.306µs; -477.182µs] or [-55.734%; -55.028%]
  • 🟩 mem_peak [-15.131MB; -15.129MB] or [-28.536%; -28.532%]

scenario:SpanBench/benchOpenTelemetryAPI-opcache

  • 🟩 execution_time [-456.528µs; -448.227µs] or [-56.673%; -55.642%]
  • 🟩 mem_peak [-15.029MB; -15.027MB] or [-30.078%; -30.074%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:LaravelBench/benchLaravelDdprof-opcache

  • unstable execution_time [-840.141µs; +742.981µs] or [-5.834%; +5.160%]

@cataphract
cataphract requested a review from a team as a code owner October 1, 2026 15:09
The test session token is part of the shared-memory path used for agent
sampling configuration. Recreate the reader and clear cached rates when
the token changes so it follows the sender endpoint.
@bwoebi
bwoebi merged commit 99ed684 into master Oct 2, 2026
2198 checks passed
@bwoebi
bwoebi deleted the glopes/new-limiter branch October 2, 2026 10:02
@github-actions github-actions Bot added this to the 1.26.0 milestone Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants