Skip to content

Unify wordpress - #4261

Merged
estringana merged 3 commits into
masterfrom
estringana/unify-wordpress
Oct 2, 2026
Merged

estringana merged 3 commits into
masterfrom
estringana/unify-wordpress

Conversation

@estringana

@estringana estringana commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Description

This PR unifies WordPress 6.1 test fixtures as the fourth step of #4149:

  • Removes the standalone appsec/tests/integration/src/test/www/wordpress61/ copy
  • Adds the appsec-specific routes and fixtures to tests/Frameworks/WordPress/Version_6_1/:
    • login and behind-auth routes
    • dynamic-path, nested and chained resources
    • verb-restricted routes
    • regex, scheme, placeholder, wildcard, and hostname routes
    • endpoint discovery
  • Adds a docker-init.sh so the AppSec container can bootstrap the app end-to-end: composer install, SQLite DB setup, and a database.local.php override of the tracer's MySQL global config
  • All test_web_wordpress_61 tracer jobs and all AppSec integration test jobs pass

Next steps

  • Roadrunner

Not doing

  • llm
  • payment
  • frankenphp

@estringana
estringana requested review from a team as code owners October 1, 2026 10:54
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-01T10:56:44.958708Z ef5d532 PR opened
🔒 Security Review ✅ Completed 2026-10-01T10:58:45.309691Z ef5d532 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 68.38% (-0.04%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0e34e1f | Docs | View more details | Give us feedback!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The shared fixture preserves the previous AppSec setup while adding focused automated-user-event coverage.

Review effort: Balanced
Findings: None

What changed in this PR

Unifies AppSec WordPress tests around the shared WordPress 6.1 fixture.

Changes:

  • Adds shared AppSec trigger scripts and Apache configuration.
  • Reuses the shared fixture from WordPressTests.
  • Aligns database configuration and removes redundant AppSec files.
File Description
tests/​Frameworks/​WordPress/​Version_6_1/​wp-config.php Makes the AppSec mock optional.
tests/​Frameworks/​WordPress/​Version_6_1/​signup_trigger.php Adds signup-event trigger.
tests/​Frameworks/​WordPress/​Version_6_1/​login_trigger.php Adds authentication trigger.
tests/​Frameworks/​WordPress/​Version_6_1/​index.php Makes the AppSec mock optional.
tests/​Frameworks/​WordPress/​Version_6_1/​hello.php Adds response-header test endpoint.
tests/​Frameworks/​WordPress/​Version_6_1/​docker-init.sh Prepares the shared fixture for AppSec Apache.
tests/​Frameworks/​WordPress/​Version_6_1/​behind_auth_trigger.php Adds authenticated-user trigger.
tests/​Frameworks/​WordPress/​Version_6_1/​.htaccess Adds WordPress routing rules.
appsec/​tests/​integration/​src/​test/​www/​wordpress/​public/​wp-config.php Removes duplicate configuration.
appsec/​tests/​integration/​src/​test/​www/​wordpress/​public/​index.php Removes duplicate entry point.
appsec/​tests/​integration/​src/​test/​www/​wordpress/​docker-init.sh Removes superseded initialization.
appsec/​tests/​integration/​src/​test/​groovy/​com/​datadog/​appsec/​php/​integration/​WordPressTests.groovy Uses the shared fixture and aligned database settings.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tests/Frameworks/WordPress/Version_6_1/docker-init.sh Outdated
Comment thread tests/Frameworks/WordPress/Version_6_1/docker-init.sh Outdated
@estringana
estringana merged commit 505493d into master Oct 2, 2026
2219 of 2222 checks passed
@estringana
estringana deleted the estringana/unify-wordpress branch October 2, 2026 10:05
@github-actions github-actions Bot added this to the 1.26.0 milestone Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants