-
Notifications
You must be signed in to change notification settings - Fork 557
fix(telemetry): rebuild worker on identity refresh #19821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: tianning.li/3-3-trace-writer-identity-refresh
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -67,6 +67,11 @@ def on_runtime_identity_refresh(cb: t.Callable[[str], None]) -> None: | |
| _ON_RUNTIME_IDENTITY_REFRESH.add(cb) | ||
|
|
||
|
|
||
| def remove_runtime_identity_refresh(cb: t.Callable[[str], None]) -> None: | ||
| """Unregister a callback for explicit runtime identity refreshes.""" | ||
| _ON_RUNTIME_IDENTITY_REFRESH.discard(cb) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
In a MicroVM, Useful? React with 👍 / 👎. |
||
|
|
||
|
|
||
| def get_runtime_identity_refresh_lock() -> t.ContextManager[None]: | ||
| """Return the lock that serializes a MicroVM identity refresh with its consumers.""" | ||
| return t.cast(t.ContextManager[None], _RUNTIME_IDENTITY_REFRESH_LOCK) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every expected MicroVM identity refresh emits a warning claiming a test regenerated the runtime ID. This creates misleading application-log noise and exposes both runtime IDs during normal production lifecycle handling.
Was this helpful? React 👍 or 👎
🤖 Bits Code Review · @DataDog review to ask questions · Open Bits AI session