-
Notifications
You must be signed in to change notification settings - Fork 3
Add Conventions and Agent Instructions documentations #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
543c416
Little reformating in Main, Security and Contributing documentations
xlamorlette-datadog 9ec21b1
Add Conventions documentation
xlamorlette-datadog 3428a45
Add Agent Instructions
xlamorlette-datadog 0b335b9
merge build and test instructions from CLAUDE.md in CONTRIBUTING.md
xlamorlette-datadog 164ac05
Add link to Conventions in Contributing
xlamorlette-datadog 0a59b3c
Fix format of Release documentation
xlamorlette-datadog 9f116ff
Change CLAUDE.md to be a symbolic link to AGENTS.md
xlamorlette-datadog 7deae76
Add Agent-Only Instructions
xlamorlette-datadog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # Agent Instructions | ||
|
|
||
| ## Conventions | ||
|
|
||
| Follow [doc/conventions.md](doc/conventions.md). | ||
|
|
||
| ## Build & Test | ||
|
|
||
| See [CONTRIBUTING.md](CONTRIBUTING.md) for build and test instructions. | ||
|
|
||
| ## Agent-Only Instructions | ||
|
|
||
| Write short comments, with simple words and short sentences. |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| AGENTS.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,18 @@ | ||
| # Security Policy | ||
|
|
||
| This document outlines the security policy for the Datadog HTTPD module and what to do if you discover a security vulnerability in the project. | ||
| Most notably, please do not share the details in a public forum (such as in a discussion, issue, or pull request) but instead reach out to us with the details. | ||
| This gives us an opportunity to release a fix for others to benefit from by the time details are made public. | ||
| # Datadog Apache Httpd Module Security Policy | ||
|
|
||
| This document outlines the security policy for the Datadog Httpd module and what to do if you | ||
| discover a security vulnerability in the project. Most notably, please do not share the details in a | ||
| public forum (such as in a discussion, issue, or pull request) but instead reach out to us with the | ||
| details. This gives us an opportunity to release a fix for others to benefit from by the time | ||
| details are made public. | ||
|
|
||
| ## Supported Versions | ||
|
|
||
| We accept vulnerability submissions for any currently maintained versions of HTTPD. | ||
|
|
||
| We accept vulnerability submissions for the [currently maintained | ||
| release](https://github.com/DataDog/httpd-datadog/releases). | ||
|
|
||
| ## Reporting a Vulnerability | ||
|
|
||
| If you discover a vulnerability please submit details to the following email address: | ||
|
|
||
| * [security@datadoghq.com](mailto:security@datadoghq.com) | ||
| If you discover a vulnerability in the Datadog Apache Httpd Module (or any Datadog product for that | ||
| matter) please submit details to the [security@datadoghq.com](mailto:security@datadoghq.com) email | ||
| address. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # Datadog Apache Httpd Module Conventions | ||
|
|
||
| This document defines repository-wide conventions for `httpd-datadog`. Apply these conventions to | ||
| all new and modified code. | ||
|
|
||
| ## C++ Version | ||
|
|
||
| The project uses C++17. | ||
|
|
||
| ## Clean Code | ||
|
|
||
| - Use meaningful variable and function names. | ||
| - Do not use single-letter variable names. | ||
| - Avoid abbreviations, unless very common and unambiguous. | ||
| - Avoid obvious comments. | ||
| - Prefer clearer variable and function names over explanatory comments. | ||
| - Keep functions small and focused (<~ 20 lines when practical). | ||
| - When practical, place caller functions before callees, so the code can be read from top to bottom. | ||
|
|
||
| ## C++ Code Style | ||
|
|
||
| - Use modern C++ idioms. | ||
| - Prefer explicit types. Use `auto` only for very long type names (>~ 50 characters). | ||
| - Never use C-style casts. | ||
| - Use raw pointers only when absolutely necessary. | ||
| - Use C++17 nested namespace syntax. | ||
| - Minimize the number of `#include` lines. Do not enforce the include-what-you-use rule. | ||
|
|
||
| ## Naming Conventions | ||
|
|
||
| - class: `class TypeName;` | ||
| - class member function: `.member_function();` | ||
| - class public member: `int public_member;` | ||
| - class private member: `int private_member_;` | ||
| - free function: `free_function();` | ||
| - function argument: `function(int func_arg);` | ||
| - local variable: `int local_var;` | ||
| - enumeration: `enum class Color { RED, GREEN, BLUE };` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these could be expressed in clang-format and clang-tidy. Then lets do it that way.
LLMs are awesome, but detereministic rules are even better :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure!
I think doing so should be done in a dedicated PR, because it could imply correcting existing code.