Enable clang-tidy tooling - #443
colin-higgins wants to merge 7 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 2e7f086 | Docs | View more details | Give us feedback! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0fb529abff
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| mapfile -t files < <(find src test/unit \ | ||
| -type f \( -name '*.cpp' -o -name '*.c' \)) |
There was a problem hiding this comment.
The CI job configures with BUILD_TESTING=OFF and RUM=OFF, so compile_commands.json contains neither test/unit nor src/rum, yet this find sends all of them to clang-tidy. Unit files require Catch2, which is not fetched when tests are disabled, and RUM files lack their configured include paths. clang-tidy then reports compiler errors and exits nonzero, so lint-tidy cannot complete in its defined CI configuration. Build the needed targets or derive the input list from compile_commands.json.
Useful? React with 👍 / 👎.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
xlamorlette-datadog
left a comment
xlamorlette-datadog
left a comment
There was a problem hiding this comment.
Before handling this PR, we should finalize the mother PR in dd-trace-cpp: DataDog/dd-trace-cpp#372.
2 participants
Add a shared clang-tidy baseline and a CI job that fails on findings, so PRs cannot merge with tidy violations.