Cache musl toolchain in GHCR for GitHub System Tests - #451
Closed
pawelchcki wants to merge 1 commit into
Closed
pawelchcki wants to merge 1 commit into
pawelchcki wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
I had some flakes regarding using public.ecr repository |
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: c4483e4 | Docs | View more details | Give us feedback! |
xlamorlette-datadog
requested changes
Sep 30, 2026
xlamorlette-datadog
left a comment
Collaborator
There was a problem hiding this comment.
#455 is a simpler solution.
I think it is also more reliable:
- Datadog public registry is built for heavy traffic, and it fixes all non-GitLab build, not just GitHub CI, notably local builds.
- Here, the publisher copies the image from
public.ecr.aws, so, as stated in the PR description, we can hit the same rate limit.
What do you think?
Contributor
Author
|
nice good to know |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
master.GITHUB_TOKEN, so the package is linked to this repository and the build job can pull it withpackages: read.This avoids repeated anonymous downloads from public ECR, which caused
toomanyrequests: Data limit exceededbefore compilation started. GitLab already uses an internal mirror; its pipeline is unchanged.Rollout
The publisher workflow runs on the first
masterpush that includes this file. Before it succeeds, System Tests continue using the current public ECR image. After publication, they use the same pinned manifest digest from GHCR. The publisher can also be rerun withworkflow_dispatchif the initial public ECR copy hits the existing quota.Validation
yqparsed both workflow files.shellcheck -s bashpassed on the new workflow scripts.git diff --checkpassed.make -n build-extended-imageconfirmed thatMUSL_TOOLCHAIN_IMAGEfrom the workflow overrides the Makefile default.