Skip to content

chore: add apm-proxy as secondary owner of RUM paths - #452

Open
pawelchcki wants to merge 2 commits into
masterfrom
pawel/codeowners-apm-proxy
Open

pawelchcki wants to merge 2 commits into
masterfrom
pawel/codeowners-apm-proxy

Conversation

@pawelchcki

@pawelchcki pawelchcki commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add @DataDog/apm-proxy as a secondary owner of src/rum and test/cases/rum in .github/CODEOWNERS.
  • In CODEOWNERS the last matching line wins. So today * @DataDog/apm-proxy does not cover these RUM paths.
  • With this change, an approval from either @DataDog/injection-platform or @DataDog/apm-proxy satisfies code ownership for them. Other paths are unchanged.

Context: #449 was approved by an apm-proxy maintainer but is still blocked by devflow/mergegate, which asks for an injection-platform approval for src/rum and test/cases/rum.

@pawelchcki
pawelchcki requested a review from a team as a code owner September 29, 2026 19:27
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-29T19:28:25.007069Z 39041fb PR opened
🔒 Security Review ✅ Completed 2026-09-29T19:31:31.748956Z 39041fb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog auto-retried 12 jobs - 12 passed on retry View in Datadog

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 69.21% (-0.08%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 59f25f3 | Docs | View more details | Give us feedback!

@pawelchcki pawelchcki changed the title chore: add apm-proxy as co-owner of all files chore: add apm-proxy as secondary owner of RUM paths Sep 29, 2026
@pawelchcki

Copy link
Copy Markdown
Contributor Author

@xavier-datadog I added these, to not unnecessarily block the changes. if either side reviews the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants