Fix the V8 layout offsets in the schema instead of publishing them - #417
Merged
Merged
Conversation
Overall package sizeSelf size: 2.6 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | pprof-format | 2.3.1 | 504.33 kB | 504.33 kB | | source-map | 0.8.0 | 185.66 kB | 185.66 kB | | node-gyp-build | 4.8.4 | 13.86 kB | 13.86 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
The nodejs_v1 discovery schema presumes the V8 Node.js builds by default (64-bit, no pointer compression, no sandbox) and fixes the four object layout values a reader needs, pinned by the schema version, rather than carrying them as OTEP-4719 process context attributes. So instead of publishing them, derive them from V8's public headers and static_assert the presumption, so a build not matching the schema will fail to compile.
szegedi
force-pushed
the
szegedi/derive-v8-layout-offsets
branch
from
September 23, 2026 13:22
ad172d8 to
7961ae8
Compare
szegedi
marked this pull request as ready for review
September 23, 2026 13:26
szegedi
requested review from
IlyasShabi,
nsavoire and
r1viollet
as code owners
September 23, 2026 13:26
|
🔗 Commit SHA: 7961ae8 | Docs | View more details | Give us feedback! |
IlyasShabi
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
The
nodejs_v1discovery schema now presumes the V8 Node.js builds by default (64-bit, no pointer compression, no sandbox) and fixes the four object layout values a reader needs, pinned by the schema version, rather than carrying them as OTEP-4719 process context attributes.So instead of publishing them, we now derive them from V8's public headers and
static_assertthe presumption, so a build not matching the schema will fail to compile.Motivation:
Simplifying the schema and the protocol surrounding it for the 99.9% of the Node.js deployments.