ci: report CI and review status to the datadog-api-spec PR - #885
Merged
Merged
Conversation
MintsInc
marked this pull request as ready for review
October 2, 2026 11:44
There was a problem hiding this comment.
More details
The workflows consistently restrict status reporting to same-repository generated branches and use the intended CI and review contexts. The aggregate status covers all five existing CI jobs.
🤖 Bits Code Review · Commit 2bf06f6 · @DataDog review to ask questions
nogates
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Generated pup PRs (
datadog-api-spec/generated/<N>) are about to be merged automatically when their spec PR merges. That merge needs the pup PR to be approved and green. Spec authors currently can't see pup's state from the spec PR, so they would enqueue too early and fail the merge queue. This PR posts the same two statuses the language clients post.Changes
reportjob inci.yml: runs after all five CI jobs, because merge-all needs the whole PR clean, not just tests. It postspup/main/uniton the spec PR.pendingrather thanfailure. The generator force-pushes the branch, andcancel-in-progressroutinely cancels the older run.main/unitbecause the action prepends the repo name.approved_status.yml: copied from the rust client's. It postspup/main/review; the context input ispup/mainbecause this action only appends/review.startsWithrather thancontainson the branch name, which is what the actions parse.Tests
Not testable before merge: it needs the matching trust policies on the spec repo's default branch. After merge, the end-to-end check runs on a throwaway spec PR:
unitchanges once CI finishes.reviewto success, and requesting changes sets it to failure.Appendix
Merge order: 2 of 3, after the matching trust policies land in the spec repo. Until the generator starts seeding them, these statuses are posted but nothing relies on them. If a token step fails, the octo-sts step log names the claim that didn't match.