Skip to content

fix(ffe/ruby): support provider-managed configuration startup - #7731

Open
pavlokhrebto wants to merge 4 commits into
mainfrom
pavlo.khrebto/FFLSDK-10/ruby-ffe-adapter-compatibility
Open

pavlokhrebto wants to merge 4 commits into
mainfrom
pavlo.khrebto/FFLSDK-10/ruby-ffe-adapter-compatibility

Conversation

@pavlokhrebto

@pavlokhrebto pavlokhrebto commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

Ruby development builds now start Remote Configuration during provider activation. The existing parametric adapter aborts when it finds that worker running, preventing shared tests from starting.

Changes and Decisions

Make adapter startup compatible with both SDK-managed and manually started Remote Configuration. Configured Feature Flags initialization waits through the OpenFeature API and returns an HTTP error on failure; generic unconfigured startup stays non-blocking. The Rails adapter uses the same public initialization API.

This compatibility change can land independently. Agentless test activation remains in #7733.

@linear-code

linear-code Bot commented Sep 15, 2026

Copy link
Copy Markdown

FFLSDK-10

@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

utils/build/docker/ruby/parametric/server.rb                            @DataDog/system-tests-reviewers
utils/build/docker/ruby/rails72/app/controllers/open_feature_controller.rb  @DataDog/system-tests-reviewers

@datadog-official

datadog-official Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Pipelines  Tests

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 144 Pipeline jobs failed

Testing the test | System Tests (cpp_httpd, prod) / End-to-end #1 / httpd 1 — 🔄 Retry may pass, looks flaky

View more details · View in GitHub Actions

Testing the test | System Tests (dotnet, dev) / End-to-end #1 / uds 1 — 🔄 Retry may pass, looks flaky

View more details · View in GitHub Actions

Testing the test | System Tests (golang, dev) / End-to-end #1 / apim 1 — 🔄 Retry may pass, looks flaky

View more details · View in GitHub Actions

View all 144 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e2ec1a4 | Docs | View more details | Give us feedback!

@pavlokhrebto pavlokhrebto changed the title fix(ffe/ruby): preserve compatible provider startup fix(ffe/ruby): support provider-managed configuration startup Sep 15, 2026
@leoromanovsky
leoromanovsky added this pull request to stack #7873 September 30, 2026 15:42
Refresh the compatibility PR while retaining only its two Ruby adapter changes.

Environment: Datadog workspace
@leoromanovsky
leoromanovsky marked this pull request as ready for review September 30, 2026 16:57
@leoromanovsky
leoromanovsky requested a review from a team as a code owner September 30, 2026 16:57
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T17:06:51.777776Z 672a545 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@vpellan vpellan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would that make sense to add the open_feature_controller to Rails 8 too?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants