fix(ffe/ruby): support provider-managed configuration startup - #7731
Open
pavlokhrebto wants to merge 4 commits into
Open
pavlokhrebto wants to merge 4 commits into
pavlokhrebto wants to merge 4 commits into
Conversation
Contributor
|
|
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 144 Pipeline jobs failed
ℹ️ InfoNo other issues found (see more)🧪 All tests passed Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: e2ec1a4 | Docs | View more details | Give us feedback! |
leoromanovsky
added this pull request to stack #7873
September 30, 2026 15:42
Refresh the compatibility PR while retaining only its two Ruby adapter changes. Environment: Datadog workspace
leoromanovsky
marked this pull request as ready for review
September 30, 2026 16:57
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
vpellan
approved these changes
Oct 1, 2026
vpellan
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Would that make sense to add the open_feature_controller to Rails 8 too?
nccatoni
approved these changes
Oct 1, 2026
leoromanovsky
removed this pull request from stack #7873
October 1, 2026 20:15
leoromanovsky
enabled auto-merge (squash)
October 1, 2026 20:15
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Ruby development builds now start Remote Configuration during provider activation. The existing parametric adapter aborts when it finds that worker running, preventing shared tests from starting.
Changes and Decisions
Make adapter startup compatible with both SDK-managed and manually started Remote Configuration. Configured Feature Flags initialization waits through the OpenFeature API and returns an HTTP error on failure; generic unconfigured startup stays non-blocking. The Rails adapter uses the same public initialization API.
This compatibility change can land independently. Agentless test activation remains in #7733.