Skip to content

Stop merging when targetting non main system-tests ref - #7874

Open
nccatoni wants to merge 5 commits into
mainfrom
nccatoni/block-non-main-pins
Open

nccatoni wants to merge 5 commits into
mainfrom
nccatoni/block-non-main-pins

Conversation

@nccatoni

Copy link
Copy Markdown
Collaborator

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Tests, manifest, weblog are modified -> you'll need a review from system-tests-reviewers: ask to one of youre co-worker familiar with the tested feature.
    • Framework is modified, or non obvious usage of it -> get a review from system-tests-core (slack)

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

.github/workflows/system-tests.yml                                      @DataDog/system-tests-core

Comment thread .github/workflows/system-tests.yml Outdated
@nccatoni
nccatoni marked this pull request as ready for review September 30, 2026 16:38
@nccatoni
nccatoni requested a review from a team as a code owner September 30, 2026 16:38
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T16:42:58.203277Z c075ff8 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@nccatoni
nccatoni enabled auto-merge (squash) September 30, 2026 16:40
@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Pipelines  Tests

✨ Unblock PR with BitsAI

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 109 Pipeline jobs failed

Testing the test | System Tests (ruby, dev) / End-to-end #1 / rails61 1 — ❌ 1 test failed · 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

❌ tests.ai_guard.test_ai_guard_sdk.Test_SDK_Disabled.test_sdk_disabled[rails61] from system_tests_suite
assert 500 == 200
 +  where 500 = HttpResponse(status_code:500, headers:{'X-Frame-Options': 'SAMEORIGIN', 'X-XSS-Protection': '1; mode=block', 'X-Conten...'Transfer-Encoding': 'chunked'}, text:{"error":"unknown keywords: :id, :tool_name, :arguments","type":"ArgumentError"}).status_code
 +    where HttpResponse(status_code:500, headers:{'X-Frame-Options': 'SAMEORIGIN', 'X-XSS-Protection': '1; mode=block', 'X-Conten...'Transfer-Encoding': 'chunked'}, text:{"error":"unknown keywords: :id, :tool_name, :arguments","type":"ArgumentError"}) = <tests.ai_guard.test_ai_guard_sdk.Test_SDK_Disabled object at 0x7f470023cd40>.request

self = <tests.ai_guard.test_ai_guard_sdk.Test_SDK_Disabled object at 0x7f470023cd40>

    def test_sdk_disabled(self):
        """Test AI Guard disabled by default, it should always return ALLOW and no span should be generated"""
>       assert self.request.status_code == 200
E       assert 500 == 200
...
Testing the test | System Tests (ruby, dev) / End-to-end #1 / uds-rails 1 — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

Testing the test | all-jobs-are-green — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

View all 109 failed jobs.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 23eb324 | Docs | View more details | Give us feedback!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants