Conversation
Contributor
|
|
mtoffl01
force-pushed
the
fix/nodejs-sdk-configuration-capabilities
branch
from
October 1, 2026 19:08
93a7f07 to
5ac37c0
Compare
mtoffl01
marked this pull request as ready for review
October 1, 2026 19:13
rachelyangdog
approved these changes
Oct 1, 2026
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 266 Pipeline jobs failed
ℹ️ InfoNo other issues found (see more)🧪 All tests passed Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 5ac37c0 | Docs | View more details | Give us feedback! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DataDog/dd-trace-js#10573 restores the legacy per-setting
APM_TRACING_*capability bits alongsideSDK_CONFIGURATION. Node.js v6.17.0 and v6.18.0 advertise onlySDK_CONFIGURATION, while the v6.19.0 release line will advertise both families, but continues to consume only sdk_config.System-tests previously treated the presence of any legacy bit as proof that a tracer consumed lib_config. This caused the dynamic-configuration parametric suite and debugger in-product enablement tests to send the wrong payload shape.
Changes
SDK_CONFIGURATIONto selectsdk_configfor Node.js 6.17.0 and later. Preserve the historical capability masks: 6.17.0–6.18.x advertise onlySDK_CONFIGURATION, while 6.19.0+ also advertise the restored per-setting bits.SDK_CONFIGURATIONplus the restored legacy bits on the 6.x release line from v6.19.0. Allow 7.0.0 prerelease main builds to advertise those extra bits without requiring them before dd-trace-js#10573 lands.Validation
Tested locally against the exact system_tests_binaries artifact produced by dd-trace-js#10573, reporting nodejs@7.0.0-pre.