Skip to content

fix(remote-config): support restored Node.js capability bits - #7917

Open
mtoffl01 wants to merge 7 commits into
mainfrom
fix/nodejs-sdk-configuration-capabilities
Open

mtoffl01 wants to merge 7 commits into
mainfrom
fix/nodejs-sdk-configuration-capabilities

Conversation

@mtoffl01

@mtoffl01 mtoffl01 commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

DataDog/dd-trace-js#10573 restores the legacy per-setting APM_TRACING_* capability bits alongside SDK_CONFIGURATION. Node.js v6.17.0 and v6.18.0 advertise only SDK_CONFIGURATION, while the v6.19.0 release line will advertise both families, but continues to consume only sdk_config.

System-tests previously treated the presence of any legacy bit as proof that a tracer consumed lib_config. This caused the dynamic-configuration parametric suite and debugger in-product enablement tests to send the wrong payload shape.

Changes

  • Treat the presence of SDK_CONFIGURATION as authoritative for Node.js after APM_TRACING registration, including when legacy capability bits are also present.
  • Preserve the existing libdatadog bit-collision safeguard for other tracers.
  • Use SDK_CONFIGURATION to select sdk_config for Node.js 6.17.0 and later. Preserve the historical capability masks: 6.17.0–6.18.x advertise only SDK_CONFIGURATION, while 6.19.0+ also advertise the restored per-setting bits.
  • Require SDK_CONFIGURATION plus the restored legacy bits on the 6.x release line from v6.19.0. Allow 7.0.0 prerelease main builds to advertise those extra bits without requiring them before dd-trace-js#10573 lands.
  • Add regression coverage for the mixed Node.js capability set and the equivalent PHP interpretation.

Validation

Tested locally against the exact system_tests_binaries artifact produced by dd-trace-js#10573, reporting nodejs@7.0.0-pre.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

tests/parametric/capabilities.yml                                       @DataDog/system-tests-reviewers
tests/parametric/test_dynamic_configuration.py                          @DataDog/system-tests-reviewers
tests/test_the_test/test_remote_config.py                               @DataDog/system-tests-reviewers
utils/_remote_config.py                                                 @DataDog/system-tests-core

@rachelyangdog rachelyangdog changed the title fix(remote-config): support restored Node.js capability bits [nodejs]: fix(remote-config): support restored Node.js capability bits Oct 1, 2026
@mtoffl01 mtoffl01 changed the title [nodejs]: fix(remote-config): support restored Node.js capability bits [nodejs]: fix(remote-config): support restored capability bits Oct 1, 2026
@mtoffl01
mtoffl01 force-pushed the fix/nodejs-sdk-configuration-capabilities branch from 93a7f07 to 5ac37c0 Compare October 1, 2026 19:08
@mtoffl01 mtoffl01 changed the title [nodejs]: fix(remote-config): support restored capability bits fix(remote-config): support restored Node.js capability bits Oct 1, 2026
@mtoffl01
mtoffl01 marked this pull request as ready for review October 1, 2026 19:13
@mtoffl01
mtoffl01 requested review from a team as code owners October 1, 2026 19:13
@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Pipelines  Tests

✨ Unblock PR with BitsAI

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 266 Pipeline jobs failed

Testing the test | System Tests (nodejs, prod) / parametric / parametric (1) — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

Testing the test | all-jobs-are-green — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

Testing the test | System Tests (nodejs, prod) / End-to-end #1 / google_genai-js@1.34.0 1 — 🔄 Retry may pass, looks flaky

View more details · View in GitHub Actions

View all 266 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5ac37c0 | Docs | View more details | Give us feedback!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants