Conversation
|
|
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 110 Pipeline jobs failed ℹ️ InfoNo other issues found (see more)🧪 All tests passed Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 8b6e312 | Docs | View more details | Give us feedback! |
29b73e4 to
25f5c05
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 25f5c0585e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ? tests/parametric/otel_env_vars/test_otel_exporter_otlp_metrics_temporality_preference.py::Test_OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE | ||
| : v2.23.0 |
There was a problem hiding this comment.
Declare the known Ruby failures in the manifest
In the Ruby 2.42.0-dev validation recorded for this change, DeLtA, mixed-case LowMemory, empty, and invalid inputs all fail, but this class-level activation leaves those cases enabled; only the specification-default and payload methods are deactivated below. Consequently the Ruby parametric job gets four ordinary failures instead of expected failures. Split the mixed-case method if necessary and add narrow manifest declarations for the affected cases before activating the expanded suite.
AGENTS.md reference: AGENTS.md:L33-L35
Useful? React with 👍 / 👎.
25f5c05 to
6edd3f5
Compare
Motivation
APMAPI-2555: extend the existing three temporality cases to cover the recognized values, parsing, and defaults specified by the OTel metrics exporter specification.
Stack 2/2: depends on #7925, which moves the original code without changing test behavior. Review and merge #7925 first. This PR targets
vpellan/move-otel-metrics-temporality-testsso its diff contains the added coverage and related declarations.Changes
OTEL_TRACES_EXPORTERunset becausenonedisables the entire Node.js tracer, including metrics.incomplete_test_appbecause metric instrument endpoints are absent; C/C++ remainmissing_feature.The registry descriptions are stale: LowMemory works in Node.js, Java, and Ruby (lowercase/uppercase), and PHP source supplies a Datadog Delta default despite the registry listing Cumulative. The local feature-map CSV lacks this newer variable; the exact ticket and live Feature Health entry independently confirm ID 645 and APMAPI-2555.
CI findings and tracking
The CI run on
6edd3f5c9exposed 22 temporality failures across eight production/development jobs, plus the C++ trace-arrival race. Laravel 11 security build failures were excluded from this work.Nine method-level
bugdeclarations reference these subtasks. Assertions still enforce the specification; documented Datadog-default differences retain their separate declarations.Validation
./format.sh: passed after the final manifest edits, including typing, import policy, formatting, and manifest validation. The unrelated empty, untrackedutils/build/docker/internal_server/app.shdirectory was temporarily moved for shellcheck and restored../run.sh TEST_THE_TEST: 635 passed, 1 xfailed after the test split and trace-wait fix. Re-ran manifest/convention checks after the final declarations: 33 passed.--skip-parametric-build.No live Feature Health evidence was changed.