Skip to content

Deactivate THREAD_CONTEXT_SHARING scenario - #7928

Merged
cbeauchesne merged 1 commit into
mainfrom
cbeauchesne/THREAD_CONTEXT_SHARING
Oct 2, 2026
Merged

cbeauchesne merged 1 commit into
mainfrom
cbeauchesne/THREAD_CONTEXT_SHARING

Conversation

@cbeauchesne

Copy link
Copy Markdown
Collaborator

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Tests, manifest, weblog are modified -> you'll need a review from system-tests-reviewers: ask to one of youre co-worker familiar with the tested feature.
    • Framework is modified, or non obvious usage of it -> get a review from system-tests-core (slack)

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

@cbeauchesne
cbeauchesne requested a review from a team as a code owner October 2, 2026 13:58
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

.github/workflows/run-end-to-end.yml                                    @DataDog/system-tests-core

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a865a16c6b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +570 to +572
# - name: Run THREAD_CONTEXT_SHARING scenario
# if: steps.build.outcome == 'success' && !cancelled() && contains(inputs.scenarios, '"THREAD_CONTEXT_SHARING"')
# run: ./run.sh THREAD_CONTEXT_SHARING

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove the disabled scenario from the CI matrix

Commenting out this step does not prevent CI from scheduling THREAD_CONTEXT_SHARING: it remains an EndToEndScenario, whose default groups include all and tracer_release (utils/_context/_scenarios/endtoend.py:196-200), and the matrix builder still creates jobs for every selected supported scenario (utils/scripts/ci_orchestrators/workflow_data.py:336-375). Those jobs perform checkout, image pulls, and weblog builds before reaching this commented block (run-end-to-end.yml:122-167), then succeed without running the requested scenario. Remove the scenario from CI selection (or exclude it upstream) so regular/full CI does not spend runners on no-op jobs and report unexecuted coverage as green.

Useful? React with 👍 / 👎.

@cbeauchesne
cbeauchesne merged commit 771e292 into main Oct 2, 2026
308 of 607 checks passed
@cbeauchesne
cbeauchesne deleted the cbeauchesne/THREAD_CONTEXT_SHARING branch October 2, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant