Deactivate THREAD_CONTEXT_SHARING scenario - #7928
Conversation
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a865a16c6b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # - name: Run THREAD_CONTEXT_SHARING scenario | ||
| # if: steps.build.outcome == 'success' && !cancelled() && contains(inputs.scenarios, '"THREAD_CONTEXT_SHARING"') | ||
| # run: ./run.sh THREAD_CONTEXT_SHARING |
There was a problem hiding this comment.
Remove the disabled scenario from the CI matrix
Commenting out this step does not prevent CI from scheduling THREAD_CONTEXT_SHARING: it remains an EndToEndScenario, whose default groups include all and tracer_release (utils/_context/_scenarios/endtoend.py:196-200), and the matrix builder still creates jobs for every selected supported scenario (utils/scripts/ci_orchestrators/workflow_data.py:336-375). Those jobs perform checkout, image pulls, and weblog builds before reaching this commented block (run-end-to-end.yml:122-167), then succeed without running the requested scenario. Remove the scenario from CI selection (or exclude it upstream) so regular/full CI does not spend runners on no-op jobs and report unexecuted coverage as green.
Useful? React with 👍 / 👎.
Motivation
Changes
Workflow
system-tests-reviewers: ask to one of youre co-worker familiar with the tested feature.system-tests-core(slack)🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟