feat(gfi): migrate plugin by oeninghe-dataport · Pull Request #447 · Dataport/polar

oeninghe-dataport · 2026-01-08T15:46:24Z

Summary

Migrate the GFI plugin.

Instructions for local reproduction and review

Open snowbox.
Click on a marker.
See the result.

Additional hints

The utils requestGfi* were migrated as-is and do not need to be reviewed therefore.

Relevant tickets, issues, et cetera

Closes #368

github-actions · 2026-01-23T09:49:02Z

PR Preview Action v1.8.1
🚀 View preview at https://Dataport.github.io/polar/pr-preview/pr-447/
Built to branch `gh-pages` at 2026-09-04 15:36 UTC. Preview will be ready when the GitHub Pages deployment is complete.

The usually helpful variables (map, stores, etc.) are auto-exported as global variables for use with the browser's devtools in snowbox.

# Conflicts: # examples/snowbox/services.js

dopenguin

Please add an example to iceberg; this maybe should include an example with a layer where the feature list is not being used
There should be no horizontal scrollbar if no features are available
Some things are missing / quite different with the featureList; some parts are connections with the markers feature. This includes:
- When hovering an element in the feature list, the feature is highlighted in the map with the hover style
- When hovering an element in the map, the feature is highlighted in the feature list (previously green); when hovering a clustered feature, all features that are part of the cluster are highlighted
- If I select a feature in the map, it is selected in the feature list
- If I select a feature in the feature list, the corresponding marker gets the selected style; currently, a yellow dot is being displayed
- If I select a feature in the feature list, the map should be centered on that feature
- If a feature is not selectable because of the configured isSelectable function, it is not being shown in the feature list

The list may not be complete, so please take a look at Meldemichel regarding the various things mentioned above.

I'll be taking a look at the components and stores once you've tackled these things.

🏓 @oeninghe-dataport

Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>

apply suggestion "use better word in comment" Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>

warm-coolguy

🏓 @oeninghe-dataport

Incomplete review, but might as well.

warm-coolguy · 2026-09-02T12:12:02Z

@@ -0,0 +1,50 @@
+<template>
+	<PolarCard
+		v-if="gfiStore.features.length > 0 || gfiStore.configuration.featureList"


This line will, when Gfi runs in the IconMenu, produce an error in situations where there's neither a featureList configured nor a feature chosen. It's also somewhat confusing that there's nothing to be seen.

Configuration:

[ { plugin: pluginGfi({ directSelect: true, coordinateSources: [ { plugin: 'pins', key: 'coordinate', }, ], layers: { [kielPolygon]: { window: true, geometry: true, }, }, }), }, ],

pls fix

I've double-checked and this happens as soon as featureList is deleted. I've checked in POLAR@2, and it's the identical (wrong) behaviour there, except that there's no error flying in the old country.

I propose these possible solutions:

Just fix it. When there's a feature chosen, it appears normally, and when there's no feature chosen and we have the GFI window open, display an appropriate instructory text about clicking something or about "clicking something hasn't occurred yet".

Don't fix it. Document that, whenever the plugin is rendered as part of the IconMenu, featureList has to be used, too. Also create an issue that describes this situation; I consider it a new-found bug in POLAR@2 (that maybe is migrated over to POLAR@3 in this step), or a missing feature, depending on what side of the coin we're looking at.

Maybe there's a third solution, or I am just missing a configuration parameter?

As documenting this bug and fixing it seems to be a similar effort, therefore, here's a fix:

467a77f

May fall together with some other issues.

Did you test this with the snowbox config or the one posted here?

If the former, I cannot reproduce it.
If the latter, this is the expected behaviour, isn't it?

I don't remember. I think the issue was me not reading Does not work together with {@link MapConfiguration.markers}. on directSelect, which I falsely assumed.

clusterF.patch

I've now constructed another funny configuration that does this:

On removing clusterDistance: 40 from examples/snowbox/services.json's entry with id 6059, it works more as expected (and I don't think we'll have to further touch that behaviour at this point). But with the clusterDistance, the GFI (and GFI environment) is broken in these regards:

Clustered feature still visible after zoom (it shouldn't be as the cluster is actually spread now)

No feature is visibly selected (features are selected without clusterDistance)

And we're showing the cluster feature instead of the clustered features

I'm not sure whether these are bugs, missing features, or just expected undefined behaviour. Depending on solution, we should maybe add/clarify that in the documentation, and maybe create issues, and maybe throw warnings in the code somewhere. I've checked @2 and it's not properly documented there.

All three points should be solved w/ 7642fa3. It is probably broken on main as the implementation is the same

warm-coolguy · 2026-09-02T12:14:36Z

+	 *
+	 * @example `['status', 'type']`
+	 *
+	 * @defaultValue Display all properties


This doesn't seem to hold with configuration:

[ { plugin: pluginGfi({ directSelect: true, coordinateSources: [ { plugin: 'pins', key: 'coordinate', }, ], layers: { [kielPolygon]: { window: true, geometry: true, }, }, }), }, ],

pls explain ?? fix

pls explain ??

The feature of the list of one features was not selected.

fix

1b69443

The fix is one-line, all other changes are just re-ordering.

still_nagging.patch

When configuring the denkmals, I don't get the "Es ist kein Objekt ausgewählt." back after closing the feature. If you've still got the kielPolygons configured, it's the same issue there, then there's no need for the patch.

This also happens in independent mode.

Source: Just saw it on my mobile device and got the white bar stuck across the screen.

warm-coolguy

@oeninghe-dataport Some more stuff.

warm-coolguy · 2026-09-04T07:17:45Z

+ * ```ts
+ * {
+ * 	geometry: true,
+ * 	window: true,


In the current setup, I've set this to false for reports, and nothing changed. Both reports and kielPolygon continued to be in the feature list. This looks like a bug to me, I assume only the kielPolygon features should be left in.

This also seems correct to me.
Fixed w/ 39ca3a1

This fix breaks feature listeners. It's a common use case that, with window: false, subscribe(map, 'gfi', 'features', ... is used to fill e.g. a form on selecting a parcel or whatnot.

21180da

I've added a feature printer for our convenience. Window should be a purely in-POLAR-UI thing.

warm-coolguy · 2026-09-04T07:46:05Z

@@ -0,0 +1,50 @@
+<template>


Not sure where to put this comment, but the whole thing just doesn't render with this configuration (I also removed the entry from IconMenu):

addPlugin( map, pluginGfi({ displayComponent: true, layoutTag: 'MIDDLE_LEFT', layers: { [reports]: { window: true, geometry: false, }, }, }) )

Maybe this falls together with #447 (comment), but I'm very unsure. Am I missing configuration?

This fails as expected.
Nothing is rendered bc there is no source to select features from.

Probably, you'd expect that the markers have an effect; to achieve this, you need to configure featureList with bindWithCoreHoverSelect.

However, while testing this, I figured out that hasActiveWindowLayers was not reactive enough w.r.t. OL.
This is fixed w/ 568f49a, fe1a784

isItMyFaultQuestionMark.patch

Config still bad?

This is a bug I also recognized; it is fixed w/ 8d15b9f

Co-authored-by: Dennis Sen <108349707+warm-coolguy@users.noreply.github.com>

…/polar into vue3/migrate-plugin-gfi

warm-coolguy

🚚 @oeninghe-dataport here comes the fun truck, unloading a batch of riddles

warm-coolguy · 2026-09-04T13:08:26Z

+	 *
+	 * @defaultValue Disabled by default
+	 */
+	multiSelect?: MultiSelect


Can't make this fly.

neverSayNoToPanda.patch

Trying to select babas:

Trying to select kikis:

If my configuration is erroneous, can you please provide the intended configuration?

Removing directSelect doesn't help. Using box yields the same behaviour.

Bonus: I held Shift instead of Strg and got this behaviour:

Do you know if there's an issue about this or where this comes from? Seems to be unrelated to GFI, but e.g. on https://static.hamburg.de/kartenclient/prod/ we have the same effect without the wobbliness. I guess we wobbled up somewhere.

Fixed w/ a063a4a, 950629c

The Shift behaviour is OL default, as seen e.g. here

warm-coolguy · 2026-09-04T13:19:43Z

+	 * The default style as seen in the example will be used for each part that is not customized.
+	 * An empty object will return the complete default style while e.g. for an object without a configured fill the default fill will be applied.
+	 */
+	customHighlightStyle?: CustomHighlightStyle


Doesn't look like this does anything.

unfulfilling.patch

issue.isThereAWorkingConfiguration(this) ? hendrik.provideWorkingConfiguration(this) : hendrik.fix({it: 'felix'})

There is none.

MasterportalAPI stealed our style.
cfb4a34

But now there is one.

customHighlightStyle: { fill: { color: '#FF0000', }, },

warm-coolguy · 2026-09-04T13:31:36Z

+	 * @defaultValue `Infinity`
+	 * @example `10`
+	 */
+	maxFeatures?: number


Setting this means nothing works anymore.

tired.patch

warm-coolguy · 2026-09-04T13:33:42Z

+		return store[activeLayersRef.key]
+	})
+
+	const activeLayers = computed(() =>


No idea what exactly went wrong, but I can totally select insivisble features atm. Maybe somewhere here. I'm more or less placing this comment randomly, but the issue is real.

pantsOnHead.patch

oeninghe-dataport added this to the POLAR@3 milestone Jan 8, 2026

oeninghe-dataport self-assigned this Jan 8, 2026

oeninghe-dataport added the refactor Refactoring of previous code label Jan 8, 2026

oeninghe-dataport linked an issue Jan 12, 2026 that may be closed by this pull request

Migration of GFI plugin to POLAR@3 #368

Open

oeninghe-dataport force-pushed the vue3/migrate-plugin-gfi branch 3 times, most recently from 58e73f6 to f941649 Compare January 16, 2026 13:12

oeninghe-dataport added 3 commits January 23, 2026 10:46

refactor(reverseGeocoder): introduce shared lib getRefStore

2f99431

feat(core): export center and extent as instable API

74e98dd

feat(core): add shared pagination component

0da4c0a

oeninghe-dataport force-pushed the vue3/migrate-plugin-gfi branch from bb7336c to 6a3129e Compare January 23, 2026 09:46

oeninghe-dataport added 5 commits February 16, 2026 14:51

test(snowbox): allow jumping to Hamburg via button

15972bf

test(snowbox): debug assistant for browser devtools

d449c8d

The usually helpful variables (map, stores, etc.) are auto-exported as global variables for use with the browser's devtools in snowbox.

feat(gfi): migrate plugin

1234994

refactor(core): make renderType a global plugin option

8757e3b

feat(gfi): improve support for different rendering options

425cfdb

oeninghe-dataport force-pushed the vue3/migrate-plugin-gfi branch from acbf752 to 425cfdb Compare February 17, 2026 15:55

Merge branch 'next' into vue3/migrate-plugin-gfi

bf71346

oeninghe-dataport marked this pull request as ready for review February 17, 2026 16:02

oeninghe-dataport requested review from dopenguin and warm-coolguy as code owners February 17, 2026 16:02

dopenguin removed the request for review from warm-coolguy February 19, 2026 09:46

Merge branch 'next' into vue3/migrate-plugin-gfi

70ff48d

# Conflicts: # examples/snowbox/services.js

dopenguin requested changes Feb 23, 2026

View reviewed changes

dopenguin and others added 5 commits February 23, 2026 19:56

Merge branch 'next' into vue3/migrate-plugin-gfi

11fe191

fix(gfi): remove legacy manual plugin prefix for console

978d718

Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>

docs: fix shared locales hint

6d60086

Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>

docs: fix shared locales hint

6182677

Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>

docs: fix shared locales hint

439ae45

Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>

warm-coolguy and others added 10 commits September 2, 2026 11:21

refactor(gfi): made code different

35a97d3

Update src/plugins/gfi/types.ts

8f2cf2e

apply suggestion "use better word in comment" Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>

Update src/plugins/gfi/types.ts

20abf54

apply suggestion "use better word in comment" Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>

docs(gfi): make feature parameter type explicit to GeoJsonFeature

7a5f597

refactor(gfi): allow ImageWMS in getWmsGfiUrl

b82e200

docs(gfi): improve inter-docs linking

9b3b479

Merge branch 'vue3/gfi-rework-markers' into vue3/migrate-plugin-gfi

fa4f103

feat(gfi): re-implement noActiveLayer

ddf71fc

Merge branch 'next' into vue3/migrate-plugin-gfi

770b5a7

fix(gfi): geometry defaults to false to be backwards-compatible

dc73a97

warm-coolguy requested changes Sep 2, 2026

View reviewed changes

fix(gfi): show a hint in iconMenu if window is invisible

467a77f

warm-coolguy requested changes Sep 4, 2026

View reviewed changes

oeninghe-dataport and others added 13 commits September 4, 2026 12:10

fix(gfi): auto-select first feature for "real-GFI" case

1b69443

docs(gfi): remove left-over merge-conflict markers

0c2bbb5

fix(gfi): show only window: true layers in featureList

39ca3a1

fix(gfi): do not assume geometryName === 'geometry'

5fce744

Co-authored-by: Dennis Sen <108349707+warm-coolguy@users.noreply.github.com>

feat: add lib function watchArray

568f49a

fix(gfi): icon for featureList is optional

1cf9ca5

fix(gfi): hasActiveWindowLayers is now OL-reactive

fe1a784

chore: add feature printer to snowbox

21180da

Merge branch 'vue3/migrate-plugin-gfi' of https://github.com/Dataport…

ac59984

…/polar into vue3/migrate-plugin-gfi

fix(gfi): close featureInformation properly w/ close button

22ff997

fix(gfi): call updateVisibleLayers also on configuration changes

8d15b9f

fix(gfi): show only window: true layers in featureList, the right way

65ce234

fix(gfi): run getNestedFeatures for geoJson with coordinate

7642fa3

warm-coolguy requested changes Sep 4, 2026

View reviewed changes

oeninghe-dataport added 3 commits September 4, 2026 16:55

fix(gfi): write geoJsonFeatures as a whole object, as it is shallowRef

a063a4a

fix(gfi): auto-select feature w/ toggleSelection

950629c

fix(gfi): use POLAR highlight style instead of masterportalapi

cfb4a34

Uh oh!

Conversation

oeninghe-dataport commented Jan 8, 2026

Summary

Instructions for local reproduction and review

Additional hints

Relevant tickets, issues, et cetera

Uh oh!

github-actions Bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Built to branch gh-pages at 2026-09-04 15:36 UTC. Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

dopenguin left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

warm-coolguy left a comment

Choose a reason for hiding this comment

Uh oh!

warm-coolguy Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

warm-coolguy Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

warm-coolguy Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

warm-coolguy Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oeninghe-dataport Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

warm-coolguy Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

warm-coolguy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

warm-coolguy Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jan 23, 2026 •

edited

Loading

Built to branch `gh-pages` at 2026-09-04 15:36 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

dopenguin left a comment •

edited

Loading

warm-coolguy Sep 2, 2026 •

edited

Loading

warm-coolguy Sep 4, 2026 •

edited

Loading

warm-coolguy Sep 4, 2026 •

edited

Loading

warm-coolguy Sep 2, 2026 •

edited

Loading

oeninghe-dataport Sep 4, 2026 •

edited

Loading

warm-coolguy Sep 4, 2026 •

edited

Loading

warm-coolguy Sep 4, 2026 •

edited

Loading