Connect from tray#1047
Merged
Merged
Conversation
filipslezaklab
requested changes
Jul 15, 2026
| PostureCheckFail: 'posture-check-fail', | ||
| } as const; | ||
|
|
||
| /** Map an MFA method to the ConnectModal view that collects it. */ |
|
|
||
| // Auto-start the MFA flow when the backend requested it for this location | ||
| // (e.g. connecting from the tray). The trigger is set in TauriEventProvider. | ||
| // Select a per-card boolean so only the matching card re-renders on the trigger. |
Contributor
There was a problem hiding this comment.
change to "Reacts to MFA requested by backend"
| const mfaMethod = | ||
| decideLocationMfaMethod(location, location.mfa_method) ?? MfaMethod.Totp; | ||
|
|
||
| // The ConnectModal is only mounted on the overview page. |
| } | ||
|
|
||
| // Full view: open the shared ConnectModal on the overview page. The | ||
| // location arrives without `connection_type`/`active` (MFA is location-only). |
| const windowLabel = getCurrentWindow().label; | ||
|
|
||
| // Compact window: select the location's instance, expand its card and | ||
| // flag it to auto-start the MFA flow so the user can enter their code inline. |
| // tray or system settings). The location is emitted as the payload directly. | ||
| // The backend targets whichever window it surfaced: the full view (if it was | ||
| // already open) or the compact tray window. Each window handles the event in | ||
| // the way native to it. |
Contributor
There was a problem hiding this comment.
change to "Backend requests the MFA flow"
| expandedLocation: number | null; | ||
| // Location id whose MFA flow should auto-start (e.g. triggered from the tray). | ||
| // Consumed and cleared by the matching location card. Not persisted so a stale | ||
| // trigger cannot fire on the next launch. |
Contributor
There was a problem hiding this comment.
Change to "Backend requested MFA"
j-chmielewski
previously approved these changes
Jul 15, 2026
filipslezaklab
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.