fix: use the app's QueryClient in useConnect/useAddToNetwork - #3053
Open
gomesalexandre wants to merge 1 commit into
Open
fix: use the app's QueryClient in useConnect/useAddToNetwork#3053gomesalexandre wants to merge 1 commit into
gomesalexandre wants to merge 1 commit into
Conversation
Both hooks constructed a new QueryClient() and called invalidateQueries() on it, which targets a fresh disconnected cache and does nothing to the app's actual queries provided in _app.js. Use useQueryClient() so the invalidation hits the real cache and dependent queries refetch after connecting a wallet or adding a network. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3052
bug
useConnectanduseAddToNetworkeach build a newQueryClientand invalidate it:That client is disconnected from the one in
pages/_app.js(<QueryClientProvider client={queryClient}>), soinvalidateQueries()invalidates an empty, unused cache. After connecting a wallet or adding a network, the app's queries never refetch.fix
Use
useQueryClient()to get the client from context, so the invalidation targets the app's real cache. Two-line change in each hook (react-query v4,useQueryClientis the v4 hook).receipts
Both hooks call
useQueryClient()unconditionally at the top of the hook (rules-of-hooks safe), and theQueryClientProviderinpages/_app.jssupplies the client.