Upgrade skia-safe to 0.153.3 - #101
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
skia-safe(andskia-bindings) from 0.99.0 to 0.153.3 inanyrender_skia.The only breaking API change we hit:
FontMgr::new_from_datanow takes aDataand au32TTC index. The oldnew_from_data(&[u8], usize)(which copied the bytes through a stream) is nownew_from_bytes(&[u8], u32), so the typeface load inscene.rsbecomes:The Metal APIs
metal.rsuses haven't changed (the only diff inskia-safe'sgpu/ganesh/mtlbetween these versions is an addedcontexts::make_ganesh). I didn't compile the Metal code locally, so macOS CI is what checks it.Tested on Linux:
cargo clippy --workspace -- -D warningsandcargo fmt --checkpass, andcargo check/cargo testpass with--all-features. As a quick check of the changed font path, I rendered a glyph run from DejaVuSans throughSkiaImageRenderer. It produced the same inked pixel count (1100) on 0.99.0 and on 0.153.3.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/0ac6651eae73486187e192c14aeea048
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/0ac6651eae73486187e192c14aeea048?variant=devin-insiders
Requested by: @nicoburns