Skip to content

Upgrade skia-safe to 0.153.3 - #101

Merged
nicoburns merged 1 commit into
mainfrom
devin/1790695397-upgrade-skia
Sep 29, 2026
Merged

nicoburns merged 1 commit into
mainfrom
devin/1790695397-upgrade-skia

Conversation

@nicoburns

Copy link
Copy Markdown
Member

Summary

Bumps skia-safe (and skia-bindings) from 0.99.0 to 0.153.3 in anyrender_skia.

The only breaking API change we hit: FontMgr::new_from_data now takes a Data and a u32 TTC index. The old new_from_data(&[u8], usize) (which copied the bytes through a stream) is now new_from_bytes(&[u8], u32), so the typeface load in scene.rs becomes:

- .new_from_data(font.data.data(), font.index as usize)
+ .new_from_bytes(font.data.data(), font.index)

The Metal APIs metal.rs uses haven't changed (the only diff in skia-safe's gpu/ganesh/mtl between these versions is an added contexts::make_ganesh). I didn't compile the Metal code locally, so macOS CI is what checks it.

Tested on Linux: cargo clippy --workspace -- -D warnings and cargo fmt --check pass, and cargo check/cargo test pass with --all-features. As a quick check of the changed font path, I rendered a glyph run from DejaVuSans through SkiaImageRenderer. It produced the same inked pixel count (1100) on 0.99.0 and on 0.153.3.

Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/0ac6651eae73486187e192c14aeea048
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/0ac6651eae73486187e192c14aeea048?variant=devin-insiders
Requested by: @nicoburns

@staging-devin-ai-integration

Copy link
Copy Markdown

I'll fix CI failures and address comments from users with write access that start with 'Devin'.

  • Disable automatic comment, CI, and merge conflict monitoring

@nicoburns
nicoburns merged commit 2d3651f into main Sep 29, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant