anyrender_skia: drop unused skia-safe textlayout feature (except on Windows) - #102
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
textlayout featuretextlayout feature (except on Windows)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
anyrender_skiaenabled skia-safe'stextlayoutfeature (SkParagraph/SkShaper), but nothing in the crate uses it; text goes throughdraw_glyphs. This PR removes it everywhere except Windows. That shrinks the Skia build and makes the feature set closer to the combinations rust-skia publishes, including the Graphite ones, which never includetextlayout.Windows keeps
textlayoutonly so it stays on prebuilt binaries. rust-skia's windows-binaries.yaml matrix hasganesh,gl,textlayout,vulkanbut noganesh,gl,vulkan, which Linux does have. Withouttextlayout, Windows +vulkanwould build Skia from source.Prebuilt binaries (checked against the skia-binaries 0.153.3 assets, and with
cargo tree --target <triple> -e featuresfor the resolved skia-bindings features):...-aarch64-apple-darwin-ganesh-gl-jpegd-jpege-metal-pdf.tar.gz.textlayout.vulkan: prebuilt exists.vulkan: no prebuilt either before or after this change.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/7b8d8492640e46d08ea6cd8b5ab63dbb
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/7b8d8492640e46d08ea6cd8b5ab63dbb?variant=devin-insiders
Requested by: @nicoburns