Use Metal-only Skia features on macOS and iOS - #106
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
skia-safe/glon macOS and iOS, whereSkiaWindowRendereruses Metal. Explicitly enableganeshalongsidemetal:glpreviously enabled Ganesh transitively. Other platforms retain GL.Keep Skia's defaults for binary-cache compatibility, removing the redundant explicit
pdfselection. Surveyed all 152 published rust-skia 0.153.3 archives: every archive includes PDF/JPEG. Apple has a minimal Ganesh + Metal archive without GL/textlayout; Linux already uses the smallest GL and GL + Vulkan combinations. Windows GL-only can omit textlayout, but GL + Vulkan still requires it, so Windows remains unchanged.Full prebuilt feature survey
Validation: formatting, Linux default check/strict Clippy, and all-feature test build pass (the crate has no tests). Resolved features match published archives for all nine desktop/Apple targets and four Linux/Windows Vulkan configurations. Strict all-feature Clippy fails on existing unused Vulkan code/argument-count lints, reproduced on
main.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/06a8de9fb4f34694b6a757de3cc36e6c
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/06a8de9fb4f34694b6a757de3cc36e6c?variant=devin-insiders
Requested by: @nicoburns