Reset scene when vello/vello_hybrid window renderers skip a frame - #107
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #98.
VelloWindowRenderer::renderandVelloHybridWindowRenderer::renderonly calledself.scene.reset()at the end of a successful frame. Whentarget_texture_view()failed (e.g. occluded/off-screen window) ormaybe_blit_and_present()errored, they returned early afterdraw_fnhad already encoded into the scene, so the next frame appended on top of it. Over many skipped frames the scene grows unbounded (invello_hybridthis eventually panics with "alpha_idx too large").Both early-return paths after
draw_fnnow reset the scene too.The other window renderers (skia, softbuffer, pixels) aren't affected: their early returns happen before drawing, or they don't keep a scene between frames.
Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/c50e2a3e1b7b4eb9af41e07d8ffb3896
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/c50e2a3e1b7b4eb9af41e07d8ffb3896?variant=devin-insiders
Requested by: @nicoburns