Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A testing PR for DioxusLabs/anyrender#103, which adds an opt-in Skia Graphite backend on macOS/iOS. Don't merge as is: it patches all anyrender crates to that PR's git branch.
Opting into Graphite
anyrender_skiadependency now setsdefault-features = false. Each feature picks an engine explicitly, because rust-skia only publishes prebuilt binaries with a single GPU engine.skia/skia-pixels/skia-softbufferenableanyrender_skia/ganesh, the same engine as before.skia-graphitefeature enablesanyrender_skia/graphite. It exists indioxus-native,browserandreadme, and is only different fromskiaon Apple.cargo run --release -p rdme --no-default-features --features skia-graphite,comrak,floats -- https://github.com/DioxusLabs/blitzNew
examples/skia_paint_bench(macOS only)paint_bench, which doesn't support Skia.paint_scene:blitz_paint::paint_scene→SkiaScenePainter.rasterize: Ganeshflush_submit_and_sync_cpu, or Graphitesnap+insert_recording+submit_and_wait.Results
VirtualMac2,1: paravirtualized GPU, 8 vCPUs, with a background iOS simulator adding load). Absolute numbers aren't representative of real Apple hardware.paint_scene) on 3 of the 4 pages. Rasterize time is within ±15%, faster on some pages and slower on others. Totals range from 3% faster to 22% slower.rdmeon Graphite:Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/7b8d8492640e46d08ea6cd8b5ab63dbb
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/7b8d8492640e46d08ea6cd8b5ab63dbb?variant=devin-insiders
Requested by: @nicoburns
WPT results
No changes in test results compared to
main.Generated by the WPT workflow.