Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Honor SVG
clip-rulethrough Stylo's CSS cascade, including presentation attributes, inheritance, stylesheet precedence, custom properties, and restyling. Inline SVG serialization supplies the computed rule tousvgso document styles outside the SVG subtree are not lost.Forward clipping rules to AnyRender, including the fill-rule arguments of CSS
clip-path: polygon(),path(), andshape(); other clips retain nonzero behavior.clip-ruleitself does not affect CSS basic shapes.Adds CPU pixel regressions for both winding rules, stylesheet/presentation-style precedence, invalid values, attribute/class mutations, and CSS basic shapes. Existing SVG/currentColor regression tests and the full
blitz-testssuite pass; workspace Clippy (-D warnings) and formatting pass.Pins reproducible AnyRender and Stylo git revisions until releases include these changes (no local checkout paths). Companion PRs: DioxusLabs/anyrender#105 and DioxusLabs/stylo#17. Stylo's fork is still on 0.20, so the pin uses the equivalent enablement patch applied to the 0.22 release already used by Blitz.
Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/e0ae5a7e77b4472fa049798331653054
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/e0ae5a7e77b4472fa049798331653054?variant=devin-insiders
Requested by: @nicoburns
WPT results
Subtests: 49 newly passing, 0 newly failing (net +49).
Full diff (12 changed tests)
Generated by the WPT workflow.