Keep ndk_context valid across Android activity recreation - #5862
Open
LucaCappelletti94 wants to merge 1 commit into
Open
LucaCappelletti94 wants to merge 1 commit into
LucaCappelletti94 wants to merge 1 commit into
Conversation
LucaCappelletti94
marked this pull request as ready for review
September 24, 2026 09:57
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Android recreates the activity, for example for the asset-path change right after a fresh install, the process survives but
ndk_contextstill points at the first activity's global ref, which wry has freed. The next asset load crashes under CheckJNI and is undefined behaviour in release.ndk_contextnow holds the Application context, which lives as long as the process.manganis::android::with_activityreads a current-activity slot thatdioxus-desktopupdates on every activity (hence the new Android-onlymanganisdependency), so plugins no longer get a destroyed activity. The manifest template also declares the configuration changes the WebView applies live (smallestScreenSize, keyboard, navigation, touchscreen, density), extending #3905.A recreated activity still shows a blank page. A stacked follow-up PR fixes that, I separated it mostly to keep this PR as small as possible.
Hopefully once rust-mobile/ndk-context#8 merges upstream, or another better solution is identified this patch can be severely trimmed and simplified.