fix(cli): sign bundled frameworks before signing the Apple app - #5864
Open
LucaCappelletti94 wants to merge 1 commit into
Open
LucaCappelletti94 wants to merge 1 commit into
LucaCappelletti94 wants to merge 1 commit into
Conversation
LucaCappelletti94
marked this pull request as ready for review
September 24, 2026 18:38
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A device build of an app with a
#[manganis::ffi] extern "Swift"plugin fails to install with "No code signature found", becausecodesign_applesigns only the outer.appand leavesDioxusSwiftPlugins.frameworkunsigned.codesignwithout--deepdoes not sign nested code, so afterdx build --codesignthe framework reports "code object is not signed at all". The simulator skips nested signatures, which is why simulator builds work. Bundled-sysdylibs have the same problem.With this PR,
codesign_applenow signs each framework and dylib inFrameworkswith the same identity before the app, as Xcode does. Symlinks are skipped, since dev builds point them at dylibs outside the bundle.Widget extensions will likely need a follow-up, since each
.appexneeds its own entitlements and provisioning profile. #5466 contains a similar loop, and whichever lands second drops the duplicate, but that PR seems stuck since April.