Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
quote and proc-macro2 dependenciesquote/proc-macro2 deps from dioxus-config-macro crate
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dioxus-config-macroonly ever emits{ #input }or(), each of which is a singleproc_macro::Group, soquote!/proc_macro2are unnecessary. The macros now build the output directly with theproc_macroAPI:Output is token-for-token identical:
Group::newspans withSpan::call_site(), which is whatquote!used too.Verified with
cargo clippy -p dioxus-config-macro --all-features -- -D warningsandcargo check -p dioxus --features web,server.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/25f5c2bd8df547a596e96b65e2b92029
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/25f5c2bd8df547a596e96b65e2b92029?variant=devin-insiders
Requested by: @nicoburns