Conversation
|
This has issues for Dioxus Desktop on Windows:
|
`send_ctrlc` sends `CTRL_BREAK_EVENT` on Windows, which Rust handles with `ExitProcess`, so desktop apps no longer received `WM_CLOSE` and skipped saving their window state. It also does not reach apps without a console. * CLI: also run `taskkill /PID` (no `/F`) on Windows to send `WM_CLOSE`, hiding its expected "success" / "not found" output. * Desktop: handle Ctrl-C / Ctrl-Break on Windows via `ctrlc` and trigger `UserWindowEvent::Shutdown`. * Fix stale timeout comment in `soft_kill`.
c68c6ec to
c980db2
Compare
|
cool; I think those are fixed -- I tested using I suppressed some taskkill output, though it only suppresses English (not sure if taskkill outputs other languages in different language Windows). |
Closes dx serve does not gracefully shutdown server on windows #5157.
Also suppresses this warning when stopping the
dxcli: