Conversation
The patched console methods put the raw arguments into the Log message.
The server expects `messages: Vec<String>`, so any non-string argument,
such as `console.log("Wee", {a: 1})`, failed to deserialize and was
dropped.
Map each argument to a string before sending: strings are kept as-is,
everything else goes through JSON.stringify, falling back to String()
when that throws or returns undefined.
Fixes DioxusLabs#5869
nicoburns
enabled auto-merge (squash)
September 30, 2026 13:44
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5869.
The patched console methods sent their raw arguments as
messages, but the devtools server expectsVec<String>. Any non-string argument, such asconsole.log("Wee", {a: 1}), failed to deserialize and the log line was dropped. Each argument is now converted to a string before sending: strings pass through, everything else goes throughJSON.stringify, falling back toString()if that throws or returns undefined.I added a spec in
patch_console.spec.tsthat fails without the change and passes with it, and regeneratedpatch_console.jsandhash.txt. I did not run the Rust checks (cargo check,make check), so they are not ticked or claimed.