Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Escape backslashes and embedded quotes in Windows linker response-file arguments for non-MSVC linker flavors. This preserves Windows path separators for GNU-style response-file parsing while keeping the existing MSVC quoting. Apply the shared helper to both response-file writers.
Closes #5847
Tests
cargo test -p dioxus-cli build::link::linker_response_file_tests::response_file_arguments_use_the_target_linker_quoting -- --exact(1 passed)cargo test -p dioxus-cli(162 passed)cargo fmt -p dioxus-cli -- --checkgit diff --checkThe Android link itself was not run locally because the Android NDK is unavailable.