Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
staging-devin-ai-integration
Bot
force-pushed
the
devin/1790445884-rect-render-simd
branch
from
September 29, 2026 15:22
cb234d4 to
41a2196
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vello_common::rect::rendercomputed per-pixel float coverage separately for every tile in a rect's top and bottom strip rows. Profiling cached glyph rendering invello_cpu(each cached glyph is drawn as a rect fill, so ~9k small rects per frame) showedrect::renderat ~20% of single-threaded time.The top and bottom rows only have three distinct tile shapes: left edge, right edge, and interior. This change computes the alpha for each of those once per row and vectorises the calculation. Output is bit-identical.
Part 1 of 3 of the CPU glyph-cache speedups. It is independent of the other two:
Fine(#)Measurements
Throwaway probe: 1600×1200 target, ~9.3k glyphs, 14px,
atlas_cache(true), mean of 60 warm frames on a noisy Linux VM. Scene encode time for the cached run, main → this branch:cargo test -p vello_cpu -p vello_commonpasses.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/55344a6e161d48b4a3a8688fabe11d4c
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/55344a6e161d48b4a3a8688fabe11d4c?variant=devin-insiders
Requested by: @nicoburns