Add devcontainer.json for Doppler engineers - #28
Merged
Merged
Conversation
This image will not be public accessible, and is for internal Doppler engineering use only.
amoses12
approved these changes
Aug 13, 2026
amoses12
left a comment
amoses12
left a comment
Contributor
There was a problem hiding this comment.
Looks good. I left a few checks, but otherwise approved.
| "features": { | ||
| "ghcr.io/dopplerhq/devcontainer-features/volume-permissions:1": { | ||
| "basePath": "/shared-volume", | ||
| "paths": ".pnpm-store,node_modules" |
Contributor
There was a problem hiding this comment.
check: are we using pnpm anywhere? I don't see a pnpm lock file, just wanted to make sure this is intentional.
| }, | ||
| "mounts": [ | ||
| "type=volume,source=${localWorkspaceFolderBasename}-shared-mount,target=/shared-volume", | ||
| "type=volume,source=${localWorkspaceFolderBasename}-shared-mount,target=${containerWorkspaceFolder}/.pnpm-store,volume-subpath=./.pnpm-store", |
Contributor
There was a problem hiding this comment.
check: same as above with npm vs pnpm.
| "mounts": [ | ||
| "type=volume,source=${localWorkspaceFolderBasename}-shared-mount,target=/shared-volume", | ||
| "type=volume,source=${localWorkspaceFolderBasename}-shared-mount,target=${containerWorkspaceFolder}/.pnpm-store,volume-subpath=./.pnpm-store", | ||
| "type=volume,source=${localWorkspaceFolderBasename}-shared-mount,target=${containerWorkspaceFolder}/node_modules,volume-subpath=./node_modules" |
Contributor
There was a problem hiding this comment.
check: do we want to run an npm install as part of creation to populate the node_modules volume so the user doesn't have to do it on first start?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This image will not be public accessible, and is for internal Doppler engineering use only.