Skybox fixes - #515
Closed
Baplar wants to merge 12 commits into
Closed
Skybox fixes#515Baplar wants to merge 12 commits into
Baplar wants to merge 12 commits into
Conversation
Baplar
force-pushed
the
procedural-skybox
branch
5 times, most recently
from
May 20, 2026 18:49
0a5cdb5 to
dcf9bc9
Compare
Baplar
marked this pull request as ready for review
May 20, 2026 19:37
Collaborator
Author
|
It works great! Works for procedural and gradient skies. The projection 360 is still broken though. According to the logs, it might actually never be instanced, so there might be an issue with its pipeline upstream. |
Collaborator
Author
|
I added a workaround for the projection 360 skybox z-fighting with what I can only assume is the clip far-plane itself. It might still be worth investigating what could possibly be z-fighting. |
Mitigates issue with ring of light in local home
Owner
|
Sorry, I merged this before the rebase happened. Thank you for the fix! |
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #424, #454, #414 and #530
Skies now work for all types: procedural, gradient, and projection 360.