Conversation
Baplar
force-pushed
the
froxel-cpu-parallel-opt-1
branch
2 times, most recently
from
May 31, 2026 17:08
1a6a61e to
9356373
Compare
It turns out that the amount of effort needed to parallelize this operation and then transpose the Vec<Vec<_>> is more costly in time than just looping sequentially, even (especially?) with large numbers of iterations.
This allows us to do parallelize the 16 depth slices, which do not have dependencies on each other. We also do a bit of intermediate values caching as a cherry on top.
Baplar
force-pushed
the
froxel-cpu-parallel-opt-1
branch
from
June 2, 2026 06:27
9356373 to
19a9e56
Compare
Owner
|
Merged, thank you! Sorry for the delays, I'll try to get to these in less than a day next time. Working on the other PRs as well. Was quite busy lately. Apologies again for the hash change not causing a clean merge. I usually check out prs and then work on them over a day or two, so if they get updated during that time then the hash will be stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.