[Particles] Add support for non-unlit materials - #618
Merged
Merged
Conversation
Baplar
marked this pull request as draft
June 2, 2026 09:52
Collaborator
Author
|
The only remaining issue that I have noticed here is that PBS materials set to AlphaBlend render as opaque billboard particles, and I can’t figure out the reason why. |
Baplar
changed the title
Texture and color always used if available. Alpha clip only used if requested by the original material. Simple diffuse lighting computed (on Unity it does not seem affected by normal maps, metallics or occlusion, so it seems to be enough).
The only remaining issue is that AlphaBlend is not respected on PBSVertexColor
Baplar
force-pushed
the
particle-non-unlit
branch
from
June 2, 2026 15:12
70da19e to
a38c3aa
Compare
Collaborator
Author
|
Found a way to make it work, not sure how "correct" it is but I couldn’t find counterexamples of particle systems not working with this change. |
Baplar
marked this pull request as ready for review
June 2, 2026 15:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the falling leaves in Frog Bog appearing as squares by supporting non-Unlit materials.
For non-Unlit materials, most variant bits are left to 0 except for Texture, Color, and conditionally AlphaClip and VertexColors.
I also added a new fake variant bit SIMPLE_LIT, similar to RENDER_BUFFER, to indicate that the source material is not Unlit and thus should be subject to diffuse lighting.
There are still a few issues with transparency for PBSVertexColor, and I can’t figure it out…