chore: fix findings from a full repo scan - #13
Merged
Merged
Conversation
Remove the dead CKV_AWS_273 Checkov skip (suppresses nothing). Correct the CKV2_AWS_10 explanation: it is a graph check needing an in-config aws_cloudwatch_log_group resource, not an unresolved-variable problem (verified by supplying real values with --var-file). State DeletionPolicy/UpdateReplacePolicy explicitly on the lock table (cfn-lint I3011) and add a regression test. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Follow-up to #12 from a full repo scan (secrets incl. full git history, dependency CVEs, actionlint, pinned-SHA verification, Checkov/tfsec/tflint/ruff/bandit, cfn-lint incl. informational rules, an IAM permission-surface review, and the real
seed.pyrun against an emulated AWS). The code is clean; this PR fixes the three small in-repo findings.CKV_AWS_273suppressed nothing (verified by removing it: still 0 failures).CKV2_AWS_10skip explanation. The comment blamed unresolved variables; supplying real values with--var-filedid not change the result. It is a graph check that needs the log group to be anaws_cloudwatch_log_groupresource in the same config, and here it is deliberately external. The skip is valid; the stated reason was wrong.DeletionPolicy/UpdateReplacePolicyexplicitly on the DynamoDB lock table (cfn-lintI3011), with a regression test. The state bucket staysRetain; the lock table holds only transient records, soDeleteis a decision rather than an omission.Risk
Low. No IAM, trust or runtime behaviour changes; the lock table's effective behaviour is unchanged (CloudFormation's default was already
Delete).Verification
pytest 59 passed; cfn-lint clean at default and with informational rules; Checkov 0 failed; ruff/bandit/gitleaks/actionlint clean;
terraform fmt/validate/teston 1.9.0 pass; 21/21 checks passing for the realseed.pyagainst moto.Not in this PR (deliberately)
Design choices flagged in the scan report:
OrgSeedAdminself-modification (documented inSECURITY.md),TerraformCIreach over all SCPs in the org, and state-bucket access logging. GitHub-side settings (theorgseedEnvironment, required status checks) are configured in repo settings, not in this diff.