Conversation
Contributor
Author
|
The breakage in sha3 is expected breakage. A goal that was not solved by The fix is to prune the branch of the proof after the |
Co-authored-by: Copilot <copilot@github.com>
strub
approved these changes
Jul 3, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
bgregoir
reviewed
Jul 3, 2026
| && EcReduction.EqTest.for_type env b1.e_ty b2.e_ty -> | ||
| List.fold_left2 (add_eqs_loc env local) eqs (b1::es1) (b2::es2) | ||
| | _, _ when EcReduction.EqTest.for_expr env e1 e2 -> | ||
| let fv1 = e_read env e1 in |
Contributor
There was a problem hiding this comment.
I don't understand why you take the union.
Normally you should take the intersection.
The success of EqTest.for_expr should garantie
That the exists a term e such that e1 --> e and e2 --> e
So the free variable of e is in the intersection of e1 and e2.
If you take the union you may have variable bound in the first memory that will be unbound in the other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #990.
Maybe this should be fixed by making the equality check in pretty printing stronger instead. I'm not sure what's right here.
Blocked by #996.