Document interaction with other Velocity plugins

[A248]

Velocity plugin developers like myself may not use Limbo, but many of our users do. Also, developing software for a cracked network requires extreme vigilance so that unauthenticated players are not assumed as trusted.

So I would like clarification: how does LimboAuth interact with other plugins? This question is very important and should definitely be stated or clarified somewhere. LimboAuth hooks into Velocity internals so the answer is not obvious.

For example:

• Is there a RegisteredServer which the player is considered connected to, while they are in limbo? What is the server name? Are server switch events fired?
• Do limbo players appear in Velocity APIs like server.getAllPlayers()?
• Can limbo players execute plugin commands, or does LimboAPI block commands during limbo?

I imagine many developers, including myself, would benefit from this information being clearly stated.

[ksqeib]

The question you asked is good, but it's not complicated either. You can learn about these behaviors through testing. I can provide a clear answer to your third question.

Limbo players cannot execute plugin commands because it will hook the entire network processing and cannot interact with Velocity's network processing during this period, so other plugins cannot receive the corresponding commands. And don't think about registering commands through the limbo API, it just adds a command completion. If you really need to execute it, you need to implement it yourself through chat.

That's all I can do to help, I hope you don't mind.

[A248]

This is valuable information, thanks. With all due respect however, I don't have the time to test other plugins' behavior, and these are things the cracked network owner should be aware of. Let's see if a LimboAPI maintainer will reply to the thread.

[mdxd44]

1. When a player is in limbo, their connected server is set to null; upon joining, a ConnectedPlayer is simply created without a server

   LimboAPI/plugin/src/main/java/net/elytrium/limboapi/injection/login/LoginListener.java

   Line 170 in b845d00

   ConnectedPlayer player = (ConnectedPlayer) CONNECTED_PLAYER_CONSTRUCTOR.invokeExact(

   or it is set manually when the plugin sends the player to limbo while they are already connected to one of the servers
   

   LimboAPI/plugin/src/main/java/net/elytrium/limboapi/server/LimboImpl.java

   Line 426 in b845d00

   player.setConnectedServer(null);

2. The player only enters the list after passing through all limbos
   

   LimboAPI/plugin/src/main/java/net/elytrium/limboapi/injection/login/LoginTasksQueue.java

   Line 223 in b845d00

   if (this.server.registerConnection(this.player)) {

   
   This happens because all limbo servers are essentially processed in the LOGIN state (from Velocity's perspective), but LimboAPI explicitly sets its own registry with packets (which is basically mirroring Velocity's registry but with additional packets) and transitions the player to the PLAY state itself
3. LimboAPI explicitly manages all packets since it assigns its own MinecraftSessionHandler (LimboSessionHandlerImpl) to the player
   

   LimboAPI/plugin/src/main/java/net/elytrium/limboapi/server/LimboImpl.java

   Line 443 in b845d00

   connection.setActiveSessionHandler(connection.getState(), sessionHandler);

   
   Chat processing occurs within it
   

   LimboAPI/plugin/src/main/java/net/elytrium/limboapi/server/LimboSessionHandlerImpl.java

   Line 327 in b845d00

   private boolean handleChat(String message) {

   
   which is passed down to the LimboSessionHandler
   

   LimboAPI/api/src/main/java/net/elytrium/limboapi/api/LimboSessionHandler.java

   Line 42 in b845d00

   default void onChat(String chat) {

   
   which is implemented and set by the plugin that creates the limbo itself

this might not be the most accurate explanation or some details might be missing