fix(FFESUPPORT-884): remediate July 2026 dependabot vulnerabilities - #285
Merged
Merged
Conversation
Re-resolve dev-only transitive deps to patched, in-range versions: - ws 8.20.0 -> 8.21.1 (GHSA ws DoS, via jest-environment-jsdom -> jsdom) - js-yaml 3.14.2 -> 3.15.0 (GHSA-h67p-54hq-rp68, via jest/istanbul) - js-yaml 4.1.1 -> 4.3.0 (GHSA-h67p-54hq-rp68, via eslint + api-documenter) - @babel/core 7.29.0 -> 7.29.7 (GHSA-4x5r-pxfx-6jf8, via jest) @microsoft/api-documenter pins js-yaml ~4.1.0 (capped at vulnerable 4.1.x) even at latest, so a scoped resolution forces that one path to ^4.2.0. Dev-only tooling; no runtime dependency moved. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the repo’s Yarn lockfile to remediate July 2026 Dependabot vulnerability alerts affecting dev-only transitive dependencies, and adds a targeted Yarn resolution to unblock a patched js-yaml 4.x for @microsoft/api-documenter.
Changes:
- Bumps vulnerable transitive packages in
yarn.lockto patched versions (notablyws,js-yaml,@babel/coreand related Babel packages). - Adds a scoped Yarn
resolutionsentry to force@microsoft/api-documenter’sjs-yamldependency to a non-vulnerable 4.x version.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| yarn.lock | Re-resolves dev transitive dependency graph to patched versions (e.g., ws@8.21.1, js-yaml@3.15.0/4.3.0, @babel/core@7.29.7). |
| package.json | Adds a targeted Yarn resolutions override for @microsoft/api-documenter/js-yaml to allow a patched js-yaml 4.x. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
🤖 Response from codex: LGTM
(codex ran locally via |
greghuels
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated from Claude
Remediates the 4 open Dependabot alerts in
js-client-sdk— all dev-only transitive dependencies. Jira: https://datadoghq.atlassian.net/browse/FFESUPPORT-884Advisories closed
Approach
Lockfile-only re-resolution to patched in-range versions, plus one scoped resolution (
"@microsoft/api-documenter/js-yaml": "^4.2.0"): api-documenter pinsjs-yaml ~4.1.0(capped at the vulnerable 4.1.x, no upstream fix even at latest), and it's a dev-only doc-gen tool where js-yaml 4.x is API-stable. No runtime/prod dependency moved.How the tests/CI protect this change
yarn install --frozen-lockfile✓;yarn typecheck✓;eslint '**/*.ts'✓.yarn test:unit— 153 tests / 11 suites pass (jsdom usesws; jest uses@babel/core; api-documenter usesjs-yaml).Deferred advisories
None — all 4 alerts addressed; none left dismissed/auto-dismissed.