fix(parse): match color function names and keywords case-insensitively - #275
Open
maximilliangrand wants to merge 1 commit into
Open
fix(parse): match color function names and keywords case-insensitively#275maximilliangrand wants to merge 1 commit into
maximilliangrand wants to merge 1 commit into
Conversation
CSS function names and keywords are ASCII case-insensitive, but culori only accepted them in lowercase: `RGB(255 0 0)`, `HSL(...)`, `OKLCH(...)`, `COLOR(display-p3 ...)`, uppercase hue units (`120DEG`), and `TRANSPARENT` all returned undefined, while `rgb(...)`/`red`/`RED`/`#FFF` worked. - Normalize identifiers (function names, keywords, color-space names, hue units) to lowercase as they are consumed by the tokenizer. - Add the `i` flag to the legacy comma-syntax rgb()/hsl() regexes and lowercase the captured hue unit before mapping it. - Match `transparent` case-insensitively. - Guard the color() profile lookup with an own-property check so identifiers inherited from Object.prototype (`constructor`, `__proto__`, …) resolve to no profile and return undefined instead of throwing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
danburzo
reviewed
Aug 21, 2026
danburzo
left a comment
danburzo
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for this PR. I’ve made a few comments, but otherwise looks good!
| if (match[3] !== undefined) { | ||
| res.h = +match[3]; | ||
| } else if (match[1] !== undefined && match[2] !== undefined) { | ||
| res.h = hueToDeg(match[1], match[2]); |
Collaborator
There was a problem hiding this comment.
Just as a stylistic preference, could you move toLowerCase() to the hueToDeg() function directly?
switch (unit?.toLowerCase()) { … }| @@ -1,5 +1,5 @@ | |||
| const parseTransparent = c => | |||
| c === 'transparent' | |||
Collaborator
There was a problem hiding this comment.
It would be useful to guard for undefined colors with c?.toLowerCase().
| while (_i < chars.length && IdentCodePoint.test(chars[_i])) { | ||
| v += chars[_i++]; | ||
| } | ||
| return v; |
Collaborator
There was a problem hiding this comment.
As noted in #276, I think instead of all the changes here we just make the input lowercase in the tokenize() function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSS function names and keywords are ASCII case-insensitive, but culori accepts them only in lowercase:
HSL(...),OKLCH(...),COLOR(display-p3 ...), legacyRGBA(…)/HSLA(…), and uppercase hue units (120DEG) are affected too — even thoughRED,RoyalBlue, and#FFFalready parse.Cause: the tokenizer preserves identifier case while every consumer compares lowercase only — the per-space function-name checks, the
color()profile lookup, the hue-unit matching, the legacy comma-syntaxrgb()/hsl()regexes, and thetransparentkeyword.Fix: lowercase identifiers as the tokenizer consumes them (they are all case-insensitive keywords in the color grammar), add the
iflag to the two legacy regexes (lowercasing the captured hue unit), and matchtransparentcase-insensitively. Since lowercasing now feedsCONSTRUCTORinto thecolor()profile lookup, I guarded that lookup with an own-property check so identifiers inherited fromObject.prototype(constructor,__proto__) returnundefinedinstead of throwing — a latent crash that already hit their lowercase forms.Added tests for the above; full suite is otherwise unchanged.